chore: delete backup code for snippet I deleted #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I deleted this snippet yesterday from production CMS. - CMD lead writer and CMD website admin agreed to always show byline. - Hiding "by:" of byline is alreaedy applied via Core-CMS styles.
wesleyboar
commented
May 8, 2024
Comment on lines
-2
to
-7
| /* To hide byline of an article by another outlet */ | ||
| /* NOTE: Requires author add "external" tag to the article */ | ||
| /* TODO: Figure out how to show external author that user enters */ | ||
| .has-blog-tag-external .byline { | ||
| display: none; | ||
| } |
There was a problem hiding this comment.
Yesterday, CMD Lead Writer and CMD Website Admin agreed to not hide this anymore.
I deleted actual snippet and updated CMS data to ensure all now visible "bylines" look good.
There was a problem hiding this comment.
| actual poster (previously, this was hidden, and was "Hedda") |
unknown poster (previously, this was hidden, and was "Hedda") |
|---|---|
 |
 |
Comment on lines
-9
to
-14
| /* To hide the "by: " in the byline */ | ||
| /* CAVEAT: The between "by:" and author name is still visible */ | ||
| /* TODO: (TUP-552) Whether to hide this in Core, TUP, or any CMS */ | ||
| .byline span { | ||
| display: none; | ||
| } |
There was a problem hiding this comment.
This code is already present and taking effect because it was migrated to Core-CMS styles 2 months ago.
There was a problem hiding this comment.
| "by" is hidden via CMS code (as on https://tacc.utexas.edu/news/latest-news/) |
|---|
 |
jarosenb
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I deleted this snippet yesterday from production CMS, because:
Related
None
Changes
Testing / UI
(previously, this was hidden, and would have been "Hedda")
(previously, this was hidden, and would have been "Hedda")
(as on https://tacc.utexas.edu/news/latest-news/)