Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not inherit blog category order from Core-CMS #455

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

wesleyboar
Copy link
Member

Overview

The setting TACC_BLOG_CATEGORY_ORDER was inherited from Core-CMS, but Core-CMS will stop setting it in its next release, so TUP must set it.

Related

None

Changes

  • added a setting that has been being inherited from Core-CMS

Testing / UI

Verify category order is the same.

Skipped.

The setting was inherited from Core-CMS, until:
TACC/Core-CMS@a8316ca
@wesleyboar wesleyboar marked this pull request as ready for review April 15, 2024 19:04
@@ -205,6 +205,7 @@
TACC_BLOG_CUSTOM_MEDIA_POST_CATEGORY = 'multimedia'
TACC_BLOG_SHOW_ABSTRACT_TAG = 'external'

TACC_BLOG_CATEGORY_ORDER = ['press-release', 'feature-story', 'multimedia', 'podcast']
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jarosenb jarosenb merged commit 352cdfa into main Aug 13, 2024
1 check passed
@jarosenb jarosenb deleted the chore/do-not-inherit-blog-category-order branch August 13, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants