Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/tup 598 running jobs cut off #369

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Fix/tup 598 running jobs cut off #369

merged 2 commits into from
Nov 10, 2023

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Nov 10, 2023 •
edited
Loading

Overview

Prevent "Running Jobs" and "Waiting Jobs" from being cut off.

How? Change ratio of columns at specific screen width range.

Related

Changes

  • reduce ratio for a screen range
  • move narrowest screen to top

Testing

  1. View System Status tale at different screen widths.
  2. The text that was cut off should never be cut off.

UI

Before After
before after
Narrow (No Change) Medium (Bug Fixed) Wide (No Change)
narrow medium wide

@wesleyboar wesleyboar marked this pull request as ready for review November 10, 2023 20:10
@wesleyboar wesleyboar merged commit 56bf6e7 into main Nov 10, 2023
1 check passed
@wesleyboar wesleyboar deleted the fix/TUP-598-running-jobs-cut-off branch November 10, 2023 20:12
@wesleyboar
Copy link
Member Author

I prematurely merged this. I should have waited for Designer feedback.

I will monitor their answer to my question, and adjust code accordingly.

wesleyboar added a commit that referenced this pull request Nov 14, 2023
@wesleyboar
fix: tup-598 sysmon horz. cut off
16c2c0c 
This was fixed by #369, which is merged in here via main.

But #369 only worked because it was tested at zoom of maybe 90%.

When tested (in PR #339) at zoom 100%, cut off still happens.

So, I'm jsut gonna tweak ratio slightly to avoid cut off.
@wesleyboar wesleyboar mentioned this pull request Nov 14, 2023
Merged
@wesleyboar
Copy link
Member Author

wesleyboar commented Nov 14, 2023 •
edited
Loading

Important
I feat I tested this at 90% zoom, because the bug came back in #339. I fixed it again, and tested at 100%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@R-Tomas-Gonzalez R-Tomas-Gonzalez R-Tomas-Gonzalez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wesleyboar @R-Tomas-Gonzalez