Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/tup-618: c-card-frontera-page migration #362

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

R-Tomas-Gonzalez
Copy link
Contributor

Overview

This attribute is already in core-styles. Deleting from tup-ui repo.

Related

Notes

This attribute is already in core-styles. Deleting from tup-ui repo.

This attribute is already in core-styles. Deleting from tup-ui repo.
Copy link
Member

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed. This style is already in Core-Styles (via TACC/Core-Styles#100).

Also, I do not test this change on tup-ui, because I know tup-ui does not use this style anymore.

@wesleyboar
Copy link
Member

P.S. I made some unrelated fixes to c-card--frontera in TACC/Core-Styles#252.

@wesleyboar wesleyboar merged commit eab873f into main Nov 2, 2023
1 check passed
@wesleyboar wesleyboar deleted the feat/tup-618-c-card-frontera-about-page branch November 2, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migrate css to core Migrate CSS to Core-CMS or Core-Styles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants