Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: save snippet "css-spacing-fixes" #350

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

wesleyboar
Copy link
Member

Overview

Save a snippet https://tacc.utexas.edu/admin/djangocms_snippet/snippet/104/change/.

Related

None.

Changes

Testing

N/A. Just saving code so it is in version control. Snippet is still in use.

UI

no excess space
Screenshot 2023-10-18 at 4 28 02 PM

@wesleyboar wesleyboar marked this pull request as ready for review October 18, 2023 21:29
@R-Tomas-Gonzalez R-Tomas-Gonzalez self-requested a review November 14, 2023 16:45
Copy link
Contributor

@R-Tomas-Gonzalez R-Tomas-Gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the status on this? Anything I can do to help push this through? What are next steps for this? How can I test this?

@wesleyboar
Copy link
Member Author

wesleyboar commented Nov 14, 2023

Oh, sorry, @R-Tomas-Gonzalez. This PR merely needs a courtesy approval. The code is already tested via snippet —

The page https://tacc.utexas.edu/systems/stampede2/ does not have more extra negative space than it should.

— This is just saving that snippet code into version control.1

Footnotes

  1. Having snippet code only as a snippet makes it impossible to locate when searching code, because snippet code is stored in database.

@R-Tomas-Gonzalez
Copy link
Contributor

Oh, sorry, @R-Tomas-Gonzalez. This PR merely needs a courtesy approval. The code is already tested via snippet —

The page https://tacc.utexas.edu/systems/stampede2/ does not have more extra negative space than it should.

— This is just saving that snippet code into version control.1

Footnotes

  1. Having snippet code only as a snippet makes it impossible to locate when searching code, because snippet code is stored in database.

Gotcha. Approved

@wesleyboar wesleyboar merged commit 1e80648 into main Nov 14, 2023
1 check passed
@wesleyboar wesleyboar deleted the chore/save-snippet-for-css-spacing branch November 14, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants