feat: tup-612 isNestedHeader prop in <SectionHeader> #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyboar
changed the title
There was a problem hiding this comment.
Originally discussed in #339 (comment). The padding-right isn't a side-effect of nested headers. Rather, it's an issue of inconsistent spacing on the sections and articles (specifically padding).
All sections have different classes. Might be helpful to have same class across the board? Not sure, because I don't have any content in my sections.
Roight?! I proposed new ticket for solving that, ideally in exactly that way. |
Right! I agree to making a new ticket. Will approve with branch is updated. |
R-Tomas-Gonzalez
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Do not nest
<header>tags.Related
Changes
Testing
<header>tag is used for the section header.UI
Unchanged
Notes
Were
<Section>used, this prop would not be necessary. But instead<PageLayout>and<SectionHeader>are used independently, allowing developers the freedom to make inconsistent layouts.I welcome ideas for other solutions (to TUP-612). But, try to avoid suggestions that result in more wrapper elements than the app already (and inconsistently) suffers.