Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: c-news #237

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

feat: c-news #237

wants to merge 17 commits into from

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Sep 19, 2023

Overview

Add the c-news pattern.

Related

Changes

  • added c-news styles
  • added c-news demo
    • copy some HTML from TACC
    • use .c-news class names
    • demo all variations
  • added c-news to CMS

Testing

Open and review:

UI

List News

Notes

Important
Note to Self. Do not support Django CMS Blog class names. After this PR is merged, update TACC/Core-CMS's Django CMS Blog templates to use .c-news class names.

Why

Preserving the source markup and classes of Django CMS Blog is not worth the effort.

  1. The source class names have zero official styles. They are meant as suggestions or starter code, not an API.
  2. My comments about piecemeal TACC changes to Django CMS templates is (a) tedious to maintain, (b) not worth the effort because source templates rarely change, (c) information that can instead be in commits, PRs, or documents.
  3. It is easier for a developer to navigate HTML and classes than a flood of comments, and a complex CSS effort to support selectors for different contexts (.c-news for TUP CMS User Updates, and .app-blog for Django CMS Blog).
  4. After performing feat: s-form-page, c-form--login, s-form--login #205 (which might have been worth the effort), I want to avoid ever building such a prison again.

@github-actions github-actions bot added the feature A new feature or replacement of existing feature label Sep 19, 2023
@wesleyboar wesleyboar added the minor A feature in backward-compatible manner label Sep 19, 2023
@wesleyboar wesleyboar changed the base branch from main to feat/tup-463 October 13, 2023 16:18
Base automatically changed from feat/tup-463 to main October 13, 2023 19:18
@wesleyboar wesleyboar added the paused Started but not actively in progress label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature or replacement of existing feature minor A feature in backward-compatible manner paused Started but not actively in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant