Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not clone bootstrap for tacc-search-bar #971

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Sep 20, 2024

Overview

Injecting the TACC search bar is not affected by the presence of Bootstrap, so don't load markup inside the custom element.

Related

Changes

  • removed cloning of markup that loads Bootstrap stylesheet

Testing

  1. Verify Bootstrap being loaded or not loaded has no effect on UI and UX.

UI

With Cloned Bootstrap Markup

with.Bootstrap.-.SD.480p.mov

Sans Cloned Bootstrap Markup

sans.Bootstrap.-.SD.480p.mov

Notes

Why? This may have had a purpose, and better CSS made that purpose moot. This may have had a theoretical-only purpose.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.29%. Comparing base (5052063) to head (b3b2142).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #971   +/-   ##
=======================================
  Coverage   65.29%   65.29%           
=======================================
  Files         438      438           
  Lines       12703    12703           
  Branches     2670     2670           
=======================================
  Hits         8294     8294           
  Misses       4173     4173           
  Partials      236      236           
Flag Coverage Δ
javascript 70.34% <ø> (ø)
unittests 60.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant