chore(client): syntax typo in button test cases #661
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure how this didn't break a pipeline… am I wrong to add these? Ref: https://jestjs.io/docs/expect#tobenull Ref: https://github.com/testing-library/jest-dom#tobedisabled
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #661 +/- ##
==========================================
- Coverage 67.12% 65.93% -1.19%
==========================================
Files 430 208 -222
Lines 13545 7471 -6074
Branches 2519 806 -1713
==========================================
- Hits 9092 4926 -4166
+ Misses 4163 2330 -1833
+ Partials 290 215 -75
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
This can be dealt with in @tacc/core-components after TACC/tup-ui#433. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Do
Overview
Fix(?) Button test case: Add parenthesis to what seem to be functions missing parentheses.
Related
Changes
Testing
UI
N/A
Notes
Reference: