chore: remove class data-files-btn #1029
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class is assigned to buttons that:
- **either** have Bootstrap btn-primary
(in which case the `.workbench-content .btn-primary` styles it)
- **or** are our custom `<Button>`
(in which case the `composes: c-button` styles it)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1029 +/- ##
==========================================
- Coverage 72.64% 72.63% -0.01%
==========================================
Files 534 534
Lines 33681 33676 -5
Branches 2989 2989
==========================================
- Hits 24466 24461 -5
Misses 9017 9017
Partials 198 198
Flags with carried forward coverage won't be shown. Click here to find out more.
|
wesleyboar
commented
Dec 3, 2024
client/src/components/DataFiles/DataFilesSidebar/DataFilesSidebar.jsx
Outdated
Show resolved
Hide resolved
client/src/components/DataFiles/DataFilesProjectMembers/_cells/ProjectRoleSelector.jsx
Outdated
Show resolved
Hide resolved
...src/components/DataFiles/DataFilesModals/DataFilesModalTables/DataFilesModalListingTable.jsx
Outdated
Show resolved
Hide resolved
…rtal into chore/remove-data-files-btn
chandra-tacc
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove the unnecessary
.data-files-btnclass.Details
This class is assigned to buttons that:
btn-primaryclass (in which case.workbench-content .btn-primarystyles it)<Button>(in which case thecomposes: c-buttonstyles it)Related
Changes
Testing
Verify styles of these buttons are unchanged:
UI
Data.Files.Add.mov
Data.Files.Copy.mov
Allocations Manage Team
Unavailable to me.1
Notes
Footnotes
I am not in a team that I have permission to manage. ↩