-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/WP-364: Ticket creation emails are not sent to 'cc' emails #1017
Open
jmcmillenmusic
wants to merge
5
commits into
main
Choose a base branch
from
bug/WP-364
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcmillenmusic
requested review from
chandra-tacc,
rstijerina,
shayanaijaz and
jalowe13
November 25, 2024 17:12
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1017 +/- ##
=======================================
Coverage 72.53% 72.53%
=======================================
Files 534 534
Lines 33758 33758
Branches 2993 2993
=======================================
Hits 24486 24486
Misses 9074 9074
Partials 198 198
Flags with carried forward coverage won't be shown. Click here to find out more.
|
rstijerina
reviewed
Nov 25, 2024
jmcmillenmusic
changed the title
Edited modal to warn users about CC email limitations
Bug/WP-364: Ticket creation emails are not sent to 'cc' emails
Nov 25, 2024
Note: unit tests are failing |
I got the failing test(s) to pass now. |
rstijerina
reviewed
Dec 18, 2024
rstijerina
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
There is a bug that prevents CC emails from receiving emails when a ticket is first created. CC emails actually receive emails when there are replies to a ticket, however.
Related
Changes
I edited the Ticket Modal to inform users that CC emails will only receive emails on ticket replies, not ticket creation.
Testing
No testing is required since this bug cannot be fixed locally.
UI
Notes
The change that we need to make must be done globally instead of locally. That change happens here. I'll reach out to the RT channel in Slack to see if we can make that change.