-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/WP-724: Mutation Hooks: Compress Files #1009
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1009 +/- ##
=======================================
Coverage ? 70.48%
=======================================
Files ? 538
Lines ? 33983
Branches ? 2936
=======================================
Hits ? 23954
Misses ? 9829
Partials ? 200
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Client side tests failing |
client/src/components/DataFiles/DataFilesModals/DataFilesCompressModal.jsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Sal Tijerina <[email protected]>
I'll come back to the tests I skipped once I get the Extract hook working with the new changes we talked about. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Works as intended
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works locally, so giving this an approval- might need Chandra's input on backend changes.
…ost['appVersion']
* Set up new branch to branch off of Compress branch * Reversed changes to files based on feedback after rebasing branch * Skipping failing test temporarily * Linted client-side code * Removed changes to files unrelated to task due to pointing a branch to a branch other than main --------- Co-authored-by: Jeff McMillen <[email protected]>
Overview
We are working on updating our current mutations to utilize TypeScript and React Query instead of React Redux. This should improve the speed and functionality of all portal systems going forward.
Changes the
compressApp
andextractApp
app parameters to objects:Related
Changes
I converted
useCompress.js
touseCompress.ts
and created a mutation that compresses the selected files into a ZIP file that gets placed in the Root directory.Testing
UI
Notes