-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task/WG-393-Asset-Detail-Pointclouds #296
Merged
Merged
+156
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds AssetPointCloud component - Adds DOMPurify package to handle Pointclouds urls - Strips args and memo logic from AssetRenderer - Creates AssetButton component to handle what user do can per each file type and links/onClick
sophia-massie
requested review from
nathanfranklin,
shayanaijaz,
taoteg and
rstijerina
December 18, 2024 21:34
sophia-massie
changed the title
branch task/WG-393-Asset-Detail-Pointclouds
task/WG-393-Asset-Detail-Pointclouds
Dec 18, 2024
nathanfranklin
requested changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. i have one small comment on variable names and then a suggestion on size of the image/point cloud preview.
nathanfranklin
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
reloading asset repeatedly on page
…etail-Pointclouds' into task/WG-393-Asset-Detail-Pointclouds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Adds asset detail view for point clouds
PR Status:
Related Jira tickets:
Summary of Changes:
Testing Steps:
UI Photos:
Notes:
Not sure that I love having the asset renderer declared and used in AssetDetail nor how the logic is laid out. Also open to suggestions on the AssetButton and what should be passed to it. 🙏