Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/bump testing library react to remove test warnings #279

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Hotfix/bump testing library react to remove test warnings #279

merged 2 commits into from
Nov 7, 2024

Conversation

nathanfranklin
Copy link
Collaborator

@nathanfranklin nathanfranklin commented Nov 7, 2024 •
edited
Loading

Overview:

Bump testing library to remove test warnings.

PR Status:

  • Ready.

Related Jira tickets:

None

Summary of Changes:

Now the warnings should only be:

  • "defaultProps" but only from core-components
  • request that wasn't properly mocked (I'm working on a PR for this)

Testing Steps:

  1. Run tests locally or look at CI

sophia-massie
sophia-massie approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanfranklin nathanfranklin merged commit 25f88db into main Nov 7, 2024
5 checks passed
@nathanfranklin nathanfranklin deleted the hotfix/bump-testing-library-react-to-remove-test-warnings branch November 7, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophia-massie sophia-massie sophia-massie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanfranklin @sophia-massie