Task/wg 193 add tup core components lib #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ignoring core-components tests in npm run test - Allow for implict any as per the tsconfigs of TUP - Allow for js to be compiled - Added styles README from TUP for our reference
|
Just a heads up, the screenshots for comparison aren't rendering for me. I think the links are broken? |
Try refreshing - I took those instructions/screen shots out. |
Remove unused import
not maintain that library
tjgrafft
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
I tested everything locally and the Loading Spinner and Error Message appeared as expected! Great job! Having these common components to work with is gonna make life so much easier for us! So thanks for moving them over!
Wanted to get you and Nathan's thoughts on the following:
- When doing the 'npm ci' command I got an output response of 8 vulnerabilities (6 moderate, 1 high, and 1 critical) Is this something in our control, that we can address?
- When doing the 'npm run build' command I got an output response of several warning related to minifying the css. Should we make a sub-task to handle this later?
@babel/traverse <7.23.2 node_modules/@babel/traverse semver 6.0.0 - 6.3.0 || 7.0.0 - 7.5.1 tough-cookie <4.1.3 vite 3.0.2 - 3.2.6 word-wrap <1.2.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
PR Status:
Related Jira tickets:
Summary of Changes:
Testing Steps:
"Main Menu
Projects
You have {x} projects."
Notes: