Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: GPR curation for Arg_Pro_Tyr_metabolism #941

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

JHL-452b
Copy link
Collaborator

Main improvements in this PR:

As proposed in #850

  • Remove ENSG00000117592 from MAR03391;
  • Remove ENSG00000117305 from MAR03935;
  • Remove ENSG00000142920 from MAR04191;
  • Remove ENSG00000184254 from MAR04683;
  • Remove ENSG00000184254 from MAR04685;
  • Remove ENSG00000184254 from MAR04686;
  • Remove ENSG00000184254 from MAR04687;
  • Remove ENSG00000118514, ENSG00000064763 from MAR06953;
  • Remove ENSG00000064763 from MAR06954;
  • Remove ENSG00000064763 from MAR06973;
  • Remove ENSG00000198099, ENSG00000196616 from MAR08530;
  • Remove ENSG00000077498 from MAR08630;
  • Remove ENSG00000131873, ENSG00000123989, ENSG00000169826, ENSG00000198108, ENSG00000147408 from MAR12002;
  • Remove ENSG00000131873, ENSG00000123989, ENSG00000169826, ENSG00000198108, ENSG00000147408 from MAR12003;
  • Remove ENSG00000142920 from model as it's not connected to any reactions after this curation.

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

Copy link

This PR has been automatically tested with GH Actions. Here is the output of the MACAW test:

Starting dead-end test...
- Found 1514 dead-end metabolites.
- Found 1319 reactions incapable of sustaining steady-state fluxes in either direction due to these dead-ends.
- Found 1977 reversible reactions that can only carry steady-state fluxes in a single direction due to dead-ends.
Starting duplicate test...
- Skipping redox duplicates because no redox_pairs and/or proton_ids were provided.
- Found 447 reactions that were some type of duplicate:
- 0 were completely identical to at least one other reaction.
- 13 involve the same metabolites but go in the opposite direction or have the opposite reversibility as at least one other reaction.
- 447 involve the same metabolites but with different coefficients as at least one other reaction.

This and a more detailed output from MACAW are also committed to data/macawResults/.

Note: In the case of multiple test runs, this post will be edited.

model/Human-GEM.yml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants