Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagged releases (for LP app) #82

Merged
merged 6 commits into from
Oct 12, 2023
Merged

Tagged releases (for LP app) #82

merged 6 commits into from
Oct 12, 2023

Conversation

noisekit
Copy link
Collaborator

@noisekit noisekit commented Oct 11, 2023

Instead of #80

We can tag any commit with release-lp-* and CI will push force that commit to release/lp branch as a @synthetixio-team user

Vercel config updated to make production releases of v3.synthetix.io from release/lp branch now.

The workflow works in github actions
image

Automated push as @synthetixio-team:
image

@noisekit noisekit requested a review from 0xjocke October 11, 2023 02:18
@noisekit noisekit self-assigned this Oct 11, 2023
@vercel
Copy link

vercel bot commented Oct 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oracle-manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 8:11am
v3-governance ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 8:11am
v3-staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 8:11am

- tests
- staking-cy
- staking-e2e-optimism-mainnet
- staking-e2e-optimism-goerli
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bachstatter this will block auto-releases

.circleci/config.yml Outdated Show resolved Hide resolved

jobs:
release-lp:
if: ${{ github.event.check_suite.conclusion == 'success' }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should tag only if commit passes tests. Otherwise release won't happen

@noisekit noisekit merged commit f40cd81 into master Oct 12, 2023
10 of 12 checks passed
@noisekit noisekit deleted the tagged-releases branch October 12, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants