Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perps V3: Update subgraph #1775

Merged
merged 8 commits into from
Aug 24, 2023
Merged

Perps V3: Update subgraph #1775

merged 8 commits into from
Aug 24, 2023

Conversation

Tburm
Copy link
Contributor

@Tburm Tburm commented Aug 15, 2023

Update the subgraph to include:

  • Match the latest testnet deploy
  • accruedFunding on the OrderSettled event
  • Index the PreviousOrderExpired event
  • Index the CollateralModified event

Note: Since the function signatures changes, we will be missing OrderSettled events from before the deploy on August 14. Since there is not mainnet deploy of the old version it shouldn't be necessary to handle both signatures.

@Tburm Tburm marked this pull request as ready for review August 15, 2023 16:26
Copy link
Contributor

@noisekit noisekit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tburm we can have subgraphs for multiple networks (see #1784 or just look at new structure of synthetix/subgraph)
I planned to update spot/perps subgraphs too after your PRs are merged.

@Tburm
Copy link
Contributor Author

Tburm commented Aug 23, 2023

@noisekit Looking at your PR, I think that will be really useful to split by network. I've already run into some conflicts as we add things to the contracts and deploy to cannon -> testnet -> mainnet where a flow like this will help a lot.

@noisekit
Copy link
Contributor

@noisekit Looking at your PR, I think that will be really useful to split by network. I've already run into some conflicts as we add things to the contracts and deploy to cannon -> testnet -> mainnet where a flow like this will help a lot.

Great. I will do similar update to perps then. Also if you give me an exact example we have conflict now that I can ensure is also resolved along the way - that would help. Want to ensure new structure allows us to deal with such issues in the least annoying way possible

@Tburm
Copy link
Contributor Author

Tburm commented Aug 23, 2023

@noisekit I think the contracts are currently in sync with cannon and OP Goerli, so likely no conflicts. We haven't changed any events since the last testnet deploy.

@Tburm Tburm merged commit c513bab into main Aug 24, 2023
4 checks passed
@Tburm Tburm deleted the perpsv3-subgraph-events branch August 24, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants