-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perps V3: Update subgraph #1775
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noisekit Looking at your PR, I think that will be really useful to split by network. I've already run into some conflicts as we add things to the contracts and deploy to cannon -> testnet -> mainnet where a flow like this will help a lot. |
Great. I will do similar update to perps then. Also if you give me an exact example we have conflict now that I can ensure is also resolved along the way - that would help. Want to ensure new structure allows us to deal with such issues in the least annoying way possible |
@noisekit I think the contracts are currently in sync with cannon and OP Goerli, so likely no conflicts. We haven't changed any events since the last testnet deploy. |
Update the subgraph to include:
accruedFunding
on theOrderSettled
eventPreviousOrderExpired
eventCollateralModified
eventNote: Since the function signatures changes, we will be missing
OrderSettled
events from before the deploy on August 14. Since there is not mainnet deploy of the old version it shouldn't be necessary to handle both signatures.