Proxy change check #1755
Proxy change check #1755
Conversation
noisekit
commented
Aug 9, 2023
•
noisekit
commented
- add scripts for each workspace with contracts to simulate release and to check for proxy change
- update gh action to run over all the workspaces with contracts
- comment out workspaces that were not published yet or have issues with build (re-enable after fixed)
- wait for Fix Infura URL for optimism mainnet #1763 to be merged first
noisekit
force-pushed
the
proxy-change-check
branch
9 times, most recently
from
7c46907
to
3ef8f9c
Compare
Codecov Report
@@ Coverage Diff @@
## main #1755 +/- ##
=======================================
Coverage 72.77% 72.77%
=======================================
Files 57 57
Lines 720 720
Branches 236 236
=======================================
Hits 524 524
Misses 167 167
Partials 29 29
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
noisekit
force-pushed
the
proxy-change-check
branch
9 times, most recently
from
64835f0
to
759d79b
Compare
noisekit
force-pushed
the
proxy-change-check
branch
from
759d79b
to
0a33409
Compare
| - project: protocol/synthetix | ||
| cannonPackage: synthetix:latest | ||
| proxy: "InitialCoreProxy" | ||
| chains: "mainnet optimistic-mainnet goerli optimistic-goerli" |
There was a problem hiding this comment.
Th reason to check all chains in one matrix run is that env setup has a big overhead and testing only one release per run is very inefficient (actual build is much faster than env setup). Bundling multiple networks for each package makes builds run slightly slower than build setup and makes matrix split more reasonable.
| --upgrade-from ${{ matrix.cannonPackage }}:latest \ | ||
| --impersonate ${{ matrix.impersonate }} | tee deployment.log | ||
|
|
||
| grep 'Successfully built package ${{ matrix.cannonPackage }}' deployment.log |
There was a problem hiding this comment.
We need to ensure that build actually happened and not simply failed (as it used to be), so the step will fail if hardhat does not actually build anything.
| @@ -35,19 +71,34 @@ jobs: | |||
| - uses: actions/checkout@v3 | |||
| - uses: actions/setup-node@v3 | |||
| with: | |||
| node-version: "18.16.0" | |||
| node-version: "16.20.1" | |||
There was a problem hiding this comment.
downgrade to 16 on purpose?
There was a problem hiding this comment.
Just saw thread on discord
There was a problem hiding this comment.
Yeah it is a bit messier than I'd like it to be
noisekit
force-pushed
the
fix-optimistic-mainnet-rpc
branch
from
8f6f993
to
eaf72ce
Compare
noisekit
force-pushed
the
proxy-change-check
branch
from
0a33409
to
48963ce
Compare
