Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go to 1.23.3 #6221

Closed
wants to merge 3 commits into from
Closed

Conversation

IngmarStein
Copy link
Contributor

Description

Changelog here: https://go.dev/doc/devel/release

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

@IngmarStein
Copy link
Contributor Author

CC @hgy59 as you've previously bumped Go in #6207

@hgy59
Copy link
Contributor

hgy59 commented Sep 6, 2024

@IngmarStein please do not upgrade minio.
There is much more to do since it has mandatory changes and needs a package migration concept. (see #5549 and #5555)

If minio fails to build with go 1.23, we must solve the minio migration first and hold back the go update (or update go to 1.22.7 only).

cc @fgma

@IngmarStein
Copy link
Contributor Author

@hgy59 I see. Maybe the old minio build can be patched for go 1.23 like this: bettercap/bettercap#1107

@hgy59
Copy link
Contributor

hgy59 commented Sep 6, 2024

@hgy59 I see. Maybe the old minio build can be patched for go 1.23 like this: bettercap/bettercap#1107

I don't see any need for Go 1.23 yet, but the completion of #5555 is long overdue.

@IngmarStein IngmarStein force-pushed the go-1.23.1 branch 2 times, most recently from b1b52b5 to 17271f8 Compare September 6, 2024 21:42
@IngmarStein
Copy link
Contributor Author

@hgy59 I've updated this PR to patch minio to build with go 1.23 instead of updating it. The patch is the result of running go get -u golang.org/x/net && go mod tidy. Up to you if you want to wait for #5555 instead.

@IngmarStein IngmarStein changed the title Update go to 1.23.1 Update go to 1.23.2 Oct 1, 2024
@IngmarStein
Copy link
Contributor Author

This PR has been updated for Go 1.23.2.

@IngmarStein IngmarStein changed the title Update go to 1.23.2 Update go to 1.23.3 Nov 10, 2024
@IngmarStein
Copy link
Contributor Author

This PR has been updated for Go 1.23.3.

@hgy59
Copy link
Contributor

hgy59 commented Nov 10, 2024

@IngmarStein please help to bring #5555 forward.
We do not want to update go before #5555 is solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants