-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mpv json ipc vendor code #400
Conversation
Update to version 1.1.13 to hopefully address #322 fully.
|
I got the same error. It seems to work again if you bring back the env code by:
Also, because |
b8b0559
to
7301870
Compare
To keep our modifications intact, I followed an inverted approach. I went to a Syncplay commit (40fef45) in which the vendor dependency had not been modified yet and compared the module in our code with version 1.1.13. Then, I went back to In the end, I compared the diffs between the two cases confirming that the vendor dependency was patched as desired. A quick verification can be done comparing the changes in this PR with the changes upstream from here iwalton3/python-mpv-jsonipc@v1.1.11...v1.1.13. I can confirm that I can correctly run IINA with the code in this branch. I would ask you all to confirm that you can also run mpv on your platforms. Side note: VSCode automatically stripped some whitespace, hence why the diff shows these extra changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it works fine for me on Windows 10 with mpv and mpv.net.
Update to version 1.1.13 to hopefully address #322 fully.