Skip to content

Commit

Permalink
Merge pull request #108 from SymbolicML:fix-interface
Browse files Browse the repository at this point in the history 
Fix interface test for `string_tree` to handle abstract strings
  • Loading branch information
@MilesCranmer
MilesCranmer authored Nov 2, 2024
2 parents 3fb963d + 9232a99 commit dbc82a5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "DynamicExpressions"
uuid = "a40a106e-89c9-4ca8-8020-a735e8728b6b"
authors = ["MilesCranmer <[email protected]>"]
version = "1.4.0"
version = "1.4.1"

[deps]
ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"
Expand Down
2 changes: 1 addition & 1 deletion src/Interfaces.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ function _check_set_constants!(ex::AbstractExpression)
return first(get_scalar_constants(ex)) ≈ x2
end
function _check_string_tree(ex::AbstractExpression)
return string_tree(ex) isa String
return string_tree(ex) isa AbstractString
end
function _check_default_node(ex::AbstractExpression{T}) where {T}
ET = typeof(ex)
Expand Down

2 comments on commit dbc82a5

@MilesCranmer
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/118570

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.4.1 -m "<description of version>" dbc82a559cc7bf61fb6654f9017bc195f209dcaf
git push origin v1.4.1

Please sign in to comment.