[Automate CI/CD Workflow] #89
Conversation
[Add logging v1 + API improvement]
| @@ -0,0 +1,89 @@ | |||
| name: Publish the latest release on PyPI | |||
|
|
|||
| on: | |||
There was a problem hiding this comment.
lets trigger on pr merge on release that we have to sort it out
on:
pull_request:
types: [closed]
branches:
- main
and there is also stable and not stable release
There was a problem hiding this comment.
Yeah I considered this, setting it to trigger on PRs that have a tag is more flexible and will be the future workflow. Setting it to main is more of centralized control for now.
I'd check more about stable and not stable release. I currently refer to llamaindex, langchain, etc.
| - name: Set up Python | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: '3.11' |
There was a problem hiding this comment.
also here we should use poetry install --no-dev
And we can make sure all tests are run successfully before the build and publish as another safety
There was a problem hiding this comment.
There is a kind of dry publish. I used it in a test file, it works. So we can also add that simulation test before publish
| python-version: '3.11' | ||
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip |
There was a problem hiding this comment.
looks like overlap and repeating previous steps, not sure this is what you have designed on the workflow
There was a problem hiding this comment.
It is just a duplication. I will remove this.
There was a problem hiding this comment.
its stil repeating, im not sure why this has to be separate from the first,
[Beta Release 0.0.0b1]
fix poetry lock
Automate the package release workflow, sync it with PyPI. Developers don't need to run
poetry publish. Instead, if we need to update a release, just checkout main repo and add version tags bygit tag version.Please review the developer notes for pushing a new release:
https://www.notion.so/Developer-Notes-on-Release-a-New-Version-bf3f5a440bfd4ba99e8f5106c1b30b90?pvs=4