Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/lancedb as vectordb added #236

Merged
merged 10 commits into from
Dec 11, 2024
Merged

Conversation

akashAD98
Copy link

@akashAD98 akashAD98 commented Oct 27, 2024

adding lancedb as vectordb support : https://github.com/lancedb/lancedb

lancedb is a Developer-friendly, serverless vector database for AI applications. Easily add long-term memory to your LLM apps!

@akashAD98
Copy link
Author

@liyin2015 please give me feedback on this .

@AyushExel
Copy link

Thanks for the PR. Looks good if the tests pass! (I'm from lancedb)

Copy link
Member

@liyin2015 liyin2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also write better pr description to explain the scope of this project/feature. Ensure all tests can pass.

adalflow/adalflow/components/retriever/lancedb_retriver.py Outdated Show resolved Hide resolved
@akashAD98
Copy link
Author

fixed the issue & all test cases are passing

@akashAD98 akashAD98 requested a review from liyin2015 November 4, 2024 13:44
@akashAD98
Copy link
Author

@liyin2015 can you please check this?

@liyin2015
Copy link
Member

@fm1320 please try to get this done by end of this week or the next week?

@akashAD98
Copy link
Author

@fm1320 @liyin2015 I hope this pr will merge this year. its been 2 months now still its pending i know your busy in wokr but it would be great if you can make it work before new year

@fm1320
Copy link
Collaborator

fm1320 commented Dec 6, 2024

@fm1320 @liyin2015 I hope this pr will merge this year. its been 2 months now still its pending i know your busy in wokr but it would be great if you can make it work before new year

Hi, will have a look more actively in the next few days

@fm1320 fm1320 added P0 Highest priority P1 2nd priority and removed P0 Highest priority labels Dec 6, 2024
@fm1320 fm1320 merged commit 7137548 into SylphAI-Inc:main Dec 11, 2024
4 checks passed
@akashAD98
Copy link
Author

@fm1320
Im not able to import any way to check it

from adalflow.components.retriever import LanceDBRetriever


ImportError Traceback (most recent call last)
in <cell line: 1>()
----> 1 from adalflow.components.retriever import LanceDBRetriever

ImportError: cannot import name 'LanceDBRetriever' from 'adalflow.components.retriever' (/usr/local/lib/python3.10/dist-packages/adalflow/components/retriever/init.py)


NOTE: If your import is failing due to a missing package, you can
manually install dependencies using either !pip or !apt.

To view examples of installing some common dependencies, click the
"Open Examples" button below.

@akashAD98
Copy link
Author

@fm1320 can youhelp me withthis

@fm1320
Copy link
Collaborator

fm1320 commented Jan 2, 2025

Hi @akashAD98 I will have a look and open an issue if needed. Thanks for flagging.

@akashAD98
Copy link
Author

Hi @akashAD98 I will have a look and open an issue if needed. Thanks for flagging.

yes please

@fm1320
Copy link
Collaborator

fm1320 commented Jan 3, 2025

Do you have lancedb installed in your environment?

@akashAD98
Copy link
Author

Do you have lancedb installed in your environment?

yes its installed & i tried

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 2nd priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants