-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/lancedb as vectordb added #236
Conversation
@liyin2015 please give me feedback on this . |
Thanks for the PR. Looks good if the tests pass! (I'm from lancedb) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also write better pr description to explain the scope of this project/feature. Ensure all tests can pass.
fixed the issue & all test cases are passing |
@liyin2015 can you please check this? |
@fm1320 please try to get this done by end of this week or the next week? |
@fm1320 @liyin2015 I hope this pr will merge this year. its been 2 months now still its pending i know your busy in wokr but it would be great if you can make it work before new year |
Hi, will have a look more actively in the next few days |
6acd7f3
to
b709393
Compare
@fm1320 from adalflow.components.retriever import LanceDBRetriever ImportError Traceback (most recent call last) ImportError: cannot import name 'LanceDBRetriever' from 'adalflow.components.retriever' (/usr/local/lib/python3.10/dist-packages/adalflow/components/retriever/init.py) NOTE: If your import is failing due to a missing package, you can To view examples of installing some common dependencies, click the
|
@fm1320 can youhelp me withthis |
Hi @akashAD98 I will have a look and open an issue if needed. Thanks for flagging. |
yes please |
Do you have lancedb installed in your environment? |
yes its installed & i tried |
adding lancedb as vectordb support : https://github.com/lancedb/lancedb
lancedb is a Developer-friendly, serverless vector database for AI applications. Easily add long-term memory to your LLM apps!