Support project documentation without CK Editor upgrade #3478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciyer
force-pushed
the
ciyer/project-docu-minimal
branch
from
a79784a to
a465c67
Compare
ciyer
temporarily deployed
to
renku-ci-ui-3478
GitHub Actions
Inactive
|
You can access the deployment of this PR at https://renku-ci-ui-3478.dev.renku.ch |
ciyer
force-pushed
the
ciyer/project-docu-minimal
branch
from
a465c67 to
2d76097
Compare
ciyer
temporarily deployed
to
renku-ci-ui-3478
GitHub Actions
Inactive
ciyer
had a problem deploying
to
renku-ci-ui-3478
GitHub Actions
Failure
ciyer
force-pushed
the
ciyer/project-docu-minimal
branch
from
5d924b5 to
52e620d
Compare
ciyer
temporarily deployed
to
renku-ci-ui-3478
GitHub Actions
Inactive
ciyer
temporarily deployed
to
renku-ci-ui-3478
GitHub Actions
Inactive
ciyer
temporarily deployed
to
renku-ci-ui-3478
GitHub Actions
Inactive
ciyer
temporarily deployed
to
renku-ci-ui-3478
GitHub Actions
Inactive
ciyer
temporarily deployed
to
renku-ci-ui-3478
GitHub Actions
Inactive
ciyer
force-pushed
the
ciyer/project-docu-minimal
branch
from
5dd97f9 to
2aa8034
Compare
ciyer
had a problem deploying
to
renku-ci-ui-3478
GitHub Actions
Error
ciyer
had a problem deploying
to
renku-ci-ui-3478
GitHub Actions
Error
ciyer
temporarily deployed
to
renku-ci-ui-3478
GitHub Actions
Inactive
ciyer
force-pushed
the
ciyer/project-docu-minimal
branch
from
2aa8034 to
e5afcce
Compare
ciyer
temporarily deployed
to
renku-ci-ui-3478
GitHub Actions
Inactive
ciyer
temporarily deployed
to
renku-ci-ui-3478
GitHub Actions
Inactive
ciyer
temporarily deployed
to
renku-ci-ui-3478
GitHub Actions
Inactive
ciyer
temporarily deployed
to
renku-ci-ui-3478
GitHub Actions
Inactive
leafty
reviewed
Jan 17, 2025
client/src/features/ProjectPageV2/ProjectPageContent/Documentation/Documentation.tsx
Show resolved
Hide resolved
client/src/features/ProjectPageV2/ProjectPageContent/Documentation/Documentation.tsx
Outdated
Show resolved
Hide resolved
client/src/features/ProjectPageV2/ProjectPageContent/Documentation/Documentation.tsx
Outdated
Show resolved
Hide resolved
client/src/features/ProjectPageV2/ProjectPageContent/Documentation/Documentation.module.scss
Outdated
Show resolved
Hide resolved
client/src/features/ProjectPageV2/ProjectPageContent/Documentation/Documentation.tsx
Outdated
Show resolved
Hide resolved
client/src/features/ProjectPageV2/ProjectPageContent/Documentation/Documentation.tsx
Outdated
Show resolved
Hide resolved
client/src/features/ProjectPageV2/ProjectPageContent/Documentation/Documentation.tsx
Outdated
Show resolved
Hide resolved
client/src/features/ProjectPageV2/ProjectPageContent/Documentation/Documentation.tsx
Outdated
Show resolved
Hide resolved
ciyer
had a problem deploying
to
renku-ci-ui-3478
GitHub Actions
Error
ciyer
had a problem deploying
to
renku-ci-ui-3478
GitHub Actions
Error
ciyer
had a problem deploying
to
renku-ci-ui-3478
GitHub Actions
Error
ciyer
had a problem deploying
to
renku-ci-ui-3478
GitHub Actions
Failure
ciyer
force-pushed
the
ciyer/project-docu-minimal
branch
from
aa4c2a6 to
c82a37b
Compare
ciyer
temporarily deployed
to
renku-ci-ui-3478
GitHub Actions
Inactive
ciyer
force-pushed
the
ciyer/project-docu-minimal
branch
from
c82a37b to
a074ae9
Compare
leafty
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
This looks good to me and can be merged.
Some general comment (does not need fixing now): trying out the feature, it seems to me that I would be much more satisfied using an editor similar to what GitHub uses (raw markdown with preview) than what CK editor offers. As seen from the screenshot, we can render language-specific code block and more (e.g. mermaid charts) while these do not get a good preview or edit support from CK editor.
There was a problem hiding this comment.
Do we need the new entries here? I'm not sure I see comments/code with these words.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate the project documentation support from the ck-editor upgrade in #3390.
Screenshots
UI changes compared to initial version
Display text if there is no documentation
Show edit view in a modal dialog
/deploy