Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redirect to newest group slug #3467

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

@leafty leafty temporarily deployed to renku-ci-ui-3467 January 3, 2025 13:31 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

RenkuBot commented Jan 3, 2025

You can access the deployment of this PR at https://renku-ci-ui-3467.dev.renku.ch

@leafty leafty temporarily deployed to renku-ci-ui-3467 January 3, 2025 14:27 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3467 January 3, 2025 14:52 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3467 January 3, 2025 15:15 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3467 January 6, 2025 09:05 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3467 January 6, 2025 09:18 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3467 January 6, 2025 09:32 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3467 January 6, 2025 09:56 — with GitHub Actions Inactive
@leafty leafty marked this pull request as ready for review January 6, 2025 10:05
@leafty leafty requested a review from a team as a code owner January 6, 2025 10:05
Copy link
Contributor

@andre-code andre-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I got it right, when a project’s namespace slug changes, it should redirect to the new one, right?

I found an example where, after changing a group slug, the project still opens with the old namespace slug. Because of this, the namespace dropdown in the project settings shows up empty and the list include the current and old namespace slug. Does this sound like something that needs fixing?

if I open the link as anonymous, it redirects as expected.

url slug

@leafty
Copy link
Member Author

leafty commented Jan 6, 2025

@andre-code this is because of 304 caching not being correct. I will try to make a fix in the backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle redirect to current slug
3 participants