Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(client): some migration step for react-router@v6 #3466

Merged
merged 4 commits into from
Jan 6, 2025
Merged

refactor(client): some migration step for react-router@v6 #3466

merged 4 commits into from
Jan 6, 2025

Conversation

leafty
Copy link
Member

@leafty leafty commented Jan 3, 2025 •
edited
Loading

@leafty leafty force-pushed the leafty/react-router-migration-5 branch from 5a70917 to f8c6d93 Compare January 3, 2025 08:45
@leafty leafty temporarily deployed to renku-ci-ui-3466 January 3, 2025 08:46 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

RenkuBot commented Jan 3, 2025

You can access the deployment of this PR at https://renku-ci-ui-3466.dev.renku.ch

@leafty leafty temporarily deployed to renku-ci-ui-3466 January 3, 2025 12:37 — with GitHub Actions Inactive
@leafty leafty force-pushed the leafty/react-router-migration-5 branch from 776b6c9 to 72b351f Compare January 3, 2025 12:48
@leafty leafty temporarily deployed to renku-ci-ui-3466 January 3, 2025 12:49 — with GitHub Actions Inactive
@leafty leafty marked this pull request as ready for review January 3, 2025 13:11
@leafty leafty requested a review from a team as a code owner January 3, 2025 13:11
lorenzo-cavazzi
lorenzo-cavazzi approved these changes Jan 5, 2025
View reviewed changes
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@leafty leafty merged commit bf3ec8b into main Jan 6, 2025
31 checks passed
@leafty leafty deleted the leafty/react-router-migration-5 branch January 6, 2025 08:26
@RenkuBot
Copy link
Contributor

RenkuBot commented Jan 6, 2025

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenzo-cavazzi lorenzo-cavazzi lorenzo-cavazzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leafty @RenkuBot @lorenzo-cavazzi