-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hide the edit button when the user does not have permissions #3462
Open
leafty
wants to merge
7
commits into
main
Choose a base branch
from
leafty/fix-3446-edit-permissions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+269
−162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leafty
temporarily deployed
to
renku-ci-ui-3462
December 20, 2024 09:19 — with
GitHub Actions
Inactive
You can access the deployment of this PR at https://renku-ci-ui-3462.dev.renku.ch |
leafty
temporarily deployed
to
renku-ci-ui-3462
December 20, 2024 09:41 — with
GitHub Actions
Inactive
leafty
had a problem deploying
to
renku-ci-ui-3462
December 20, 2024 10:40 — with
GitHub Actions
Failure
leafty
temporarily deployed
to
renku-ci-ui-3462
December 20, 2024 10:56 — with
GitHub Actions
Inactive
leafty
changed the title
Hide the edit button when the user does not have permissions
fix: hide the edit button when the user does not have permissions
Dec 20, 2024
leafty
had a problem deploying
to
renku-ci-ui-3462
December 20, 2024 11:08 — with
GitHub Actions
Failure
leafty
force-pushed
the
leafty/fix-3446-edit-permissions
branch
from
December 20, 2024 12:23
daabf33
to
ec512b1
Compare
leafty
had a problem deploying
to
renku-ci-ui-3462
December 20, 2024 12:23 — with
GitHub Actions
Failure
leafty
force-pushed
the
leafty/fix-3446-edit-permissions
branch
from
December 20, 2024 12:39
ec512b1
to
f3a5a57
Compare
leafty
had a problem deploying
to
renku-ci-ui-3462
December 20, 2024 12:39 — with
GitHub Actions
Failure
leafty
temporarily deployed
to
renku-ci-ui-3462
December 20, 2024 12:52 — with
GitHub Actions
Inactive
leafty
temporarily deployed
to
renku-ci-ui-3462
January 3, 2025 08:48 — with
GitHub Actions
Inactive
leafty
temporarily deployed
to
renku-ci-ui-3462
January 3, 2025 08:59 — with
GitHub Actions
Inactive
lorenzo-cavazzi
previously approved these changes
Jan 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! 🚀
client/src/features/dataConnectorsV2/components/DataConnectorActions.tsx
Outdated
Show resolved
Hide resolved
leafty
commented
Jan 6, 2025
client/src/features/dataConnectorsV2/components/DataConnectorActions.tsx
Outdated
Show resolved
Hide resolved
leafty
had a problem deploying
to
renku-ci-ui-3462
January 6, 2025 08:29 — with
GitHub Actions
Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3446.
Update the actions buttons on the project / group / user pages to be presented only when the corresponding action is available to the user.
Project Page - Code Repositories
Can edit project
Cannot edit project
Project Page - Sessions
Can edit project
Cannot edit project
Project Page - Data Connectors
Can edit data connector & Can edit project
Can edit data connector & Cannot edit project
Cannot edit data connector & Can edit project
Cannot edit data connector & Cannot edit project
Anonymous user (cannot save credentials)
Group or User Page - Data Connectors
Can delete data connector (owner)
Can edit data connector
Cannot edit data connector
Anonymous user (cannot save credentials)
/deploy