Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: allow copying projects (#3393) #3427

Merged
merged 7 commits into from
Jan 6, 2025
Merged

feat!: allow copying projects (#3393) #3427

merged 7 commits into from
Jan 6, 2025
+1,747 −54

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented Dec 5, 2024 •
edited
Loading

Testing

  • copy a regular project
  • break the copy link
  • mark a project as a template and see that banners are shown
    • when viewing a project that is a template, but for which you are not an owner
    • when viewing a project that is a template, where you are an owner

/deploy renku=release-0.63.0

@ciyer ciyer added the ShapeUp label Dec 5, 2024
@ciyer ciyer changed the title feat: allow copying projects (#3393) feat!: allow copying projects (#3393) Dec 5, 2024
@ciyer ciyer force-pushed the build/project-copy branch 3 times, most recently from c574f2e to 36474e4 Compare December 17, 2024 09:57
@ciyer ciyer force-pushed the build/project-copy branch from 36474e4 to ea90f6e Compare December 18, 2024 08:59
@ciyer ciyer temporarily deployed to renku-ci-ui-3427 December 18, 2024 08:59 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3427.dev.renku.ch

@ciyer ciyer force-pushed the build/project-copy branch from 89037d6 to ea90f6e Compare December 18, 2024 09:59
@ciyer ciyer temporarily deployed to renku-ci-ui-3427 December 18, 2024 10:00 — with GitHub Actions Inactive
@ciyer ciyer force-pushed the build/project-copy branch from ea90f6e to cae6aa2 Compare December 18, 2024 10:06
@ciyer ciyer temporarily deployed to renku-ci-ui-3427 December 18, 2024 10:06 — with GitHub Actions Inactive
@ciyer ciyer force-pushed the build/project-copy branch from cae6aa2 to f3300a2 Compare December 18, 2024 10:49
@ciyer ciyer temporarily deployed to renku-ci-ui-3427 December 18, 2024 10:49 — with GitHub Actions Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-3427 December 18, 2024 14:49 — with GitHub Actions Inactive
@ciyer ciyer force-pushed the build/project-copy branch from ab0f5a1 to db1a39b Compare January 6, 2025 08:09
@ciyer ciyer temporarily deployed to renku-ci-ui-3427 January 6, 2025 08:09 — with GitHub Actions Inactive
ciyer added 2 commits January 6, 2025 09:54
@ciyer
feat!: support template projects (#3393) (#3408)
a56860b 
BREAKING CHANGES: required renku-data-services >= 0.28.0
@ciyer
feat: break copy link (#3448)
20b95e5
@ciyer ciyer force-pushed the build/project-copy branch from db1a39b to 20b95e5 Compare January 6, 2025 08:54
@ciyer ciyer temporarily deployed to renku-ci-ui-3427 January 6, 2025 09:21 — with GitHub Actions Inactive
@ciyer ciyer marked this pull request as ready for review January 6, 2025 09:28
@ciyer ciyer requested a review from a team as a code owner January 6, 2025 09:28
leafty
leafty previously approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! 👏

Some small comments below, but they do not need to be resolved immediately.

For the tests, it may be necessary to delete the deployment, delete the PVCs and re-deploy. It it unfortunately quite common for the KG to have database issues when deployments are a bit old.

client/src/components/PrimaryAlert.module.scss Outdated

.primaryAlert {
--bs-primary-bg-subtle: #{tint-color($primary, 90%)};
max-height: 50vh;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other alerts do not have this CSS rule. Maybe it should not be here by default.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 63fa000

client/src/components/buttons/Button.tsx Outdated
Comment on lines 186 to 189
// ! Temporary workaround to quickly implement a design solution -- to be removed ASAP #3250
const additionalProps = preventPropagation
? { onClick: (e: React.MouseEvent) => e.stopPropagation() }
: {};
Copy link
Member

@leafty leafty Jan 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are not using this button on interactive elements, then you do not need this workaround. Interactive elements should not be nested in the DOM tree (e.g. having <button> as a descendant of <a>).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in a4a6efa

andre-code
andre-code previously approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@andre-code andre-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected, great work! 🎉
There’s a small visual issue: the space between the badge (number) and the "copy" text feels a bit awkward. While it’s not urgent, it would be better if the space between the badge and the text wasn’t underlined.

Screenshot 2025-01-06 at 10 50 37

@ciyer ciyer dismissed stale reviews from andre-code and leafty via c86fcc9 January 6, 2025 10:36
@ciyer ciyer temporarily deployed to renku-ci-ui-3427 January 6, 2025 10:36 — with GitHub Actions Inactive
@ciyer
Copy link
Contributor Author

ciyer commented Jan 6, 2025

It works as expected, great work! 🎉 There’s a small visual issue: the space between the badge (number) and the "copy" text feels a bit awkward. While it’s not urgent, it would be better if the space between the badge and the text wasn’t underlined.

Screenshot 2025-01-06 at 10 50 37

Fixed in a195420

@ciyer
Copy link
Contributor Author

ciyer commented Jan 6, 2025

Thanks for the reviews, everyone. I have made the requested changes.

@ciyer ciyer merged commit 772f0a2 into main Jan 6, 2025
19 checks passed
@ciyer ciyer deleted the build/project-copy branch January 6, 2025 13:02
@RenkuBot
Copy link
Contributor

RenkuBot commented Jan 6, 2025

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leafty leafty leafty approved these changes

@andre-code andre-code andre-code left review comments

Assignees
No one assigned
Labels
ShapeUp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ciyer @RenkuBot @leafty @andre-code