feat: save secrets on storage create

[ciyer]

Allow storing credentials when a storage is created.

Screenshots

Add an option to save credentials to the last page of the add data source flow

When checked, the credentials will be stored after the data source is added. This can be verified by looking at the data source, the credential field will be displayed as

Testing

Add a data source that requires credentials to a project (or example an S3 or polybox data source). Check that the credentials used to test are stored. Also, check that there is no option to store credentials for a public data source (like a public S3 bucket).

/deploy renku-notebooks=master renku-data-services=main

[RenkuBot]

You can access the deployment of this PR at https://renku-ci-ui-3274.dev.renku.ch

[andre-code]

The code looks good overall, but there are a few issues that need to be addressed:

1. The secret title is currently displayed as the ID, but this ID is not shown in the data storage information. It would be better to use a more descriptive name, such as project/data-storageName.

2. When a secret is added while launching the store, it is saved as a user secret but doesn't show in the user secret list and does not indicate that it is saved in the storage information as <saved credential>.

3. The icons are not properly aligned. I’ve left a comment in the code regarding this issue.

4. The data storage sidebar should not open when clicking on the form label while editing a data storage.
   

5. Clicking on user secrets redirects to Renku 1.0. It would be better to have a Renku 2.0 route for user secrets when accessed from Renku 2.0.

6. Here would be helpful to confirm that the secret is also created successfully.

6. The checkbox to store the secret is not shown when creating the data source, although the secret is still stored.

Please address these issues here or create new issues to handle them in a separate PR

[ciyer]

Thanks for the review!

2. When a secret is added while launching the store, it is saved as a user secret but doesn't show in the user secret list and does not indicate that it is saved in the storage information as <saved credential>.
3. The icons are not properly aligned. I’ve left a comment in the code regarding this issue.
4. [After skipping the credentials test, the] checkbox to store the secret is not shown when creating the data source, although the secret is still stored.

These bugs have been fixed.

6. Here would be helpful to confirm that the secret is also created successfully.

I added this information to the dialog box

4. The data storage sidebar should not open when clicking on the form label while editing a data storage.

You are right -- I was able to reproduce this bug, but it has been around for longer, and was not introduced by the changes here. I will address it in a separate PR.

1. The secret title is currently displayed as the ID, but this ID is not shown in the data storage information. It would be better to use a more descriptive name, such as project/data-storageName.

2. Clicking on user secrets redirects to Renku 1.0. It would be better to have a Renku 2.0 route for user secrets when accessed from Renku 2.0.

I agree, the current display of the secrets is not really usable. These limitations, however, were deemed acceptable in realizing the pitch, and improving the display will require changes to the backend because there is no efficient way to get the data source that a secret is for, so this will need to be handled separately, with support from the backend.

Please address these issues here or create new issues to handle them in a separate PR

[andre-code]

Thanks for applying those fixes!

I've noticed one issue and a couple of minor CSS adjustments that need attention:

[Bug] If the storage secret is removed from the secret page, the status on the project page doesn't update. As a result, when launching the session, the missing credential is not required.

[CSS] In the storage credential modal, there's no vertical padding between fields. Please add some padding.

[CSS] Similarly, on the data source page, there's no vertical padding between "Required credentials" and "Access mode." Please address this as well.

[ciyer]

Thanks for the review, I have fixed the issues you have raised.

[Bug] If the storage secret is removed from the secret page, the status on the project page doesn't update. As a result, when launching the session, the missing credential is not required.

Fixed in 311382d

[CSS] In the storage credential modal, there's no vertical padding between fields. Please add some padding.

Fixed in 65ce6e4

[CSS] Similarly, on the data source page, there's no vertical padding between "Required credentials" and "Access mode." Please address this as well.

Fixed in 212c0c5

[andre-code]

lgtm 🚀

[RenkuBot]

Tearing down the temporary RenkuLab deplyoment for this PR.