feat!: add a convenient way to add an openBIS cloud storage #3238
Conversation
| @@ -119,6 +119,8 @@ export interface CloudStorageSchema { | |||
| hide?: boolean; | |||
| prefix: string; // ? weird naming; it's the machine readable name | |||
| position?: number; | |||
| convenientMode?: boolean; // ? Disables the advanced mode | |||
There was a problem hiding this comment.
I don't think we should include this; even if it makes little sense for users to mess with the config directly, they might still want to copy/paste the configuration string to pass it to other users to simplify setting up a working solution. I think we should remove it.
| const selectedSchema = useMemo( | ||
| () => getSchemaStorage(schema, !state.showAllSchema, storage.schema), | ||
| [schema, state.showAllSchema, storage.schema] | ||
| ).find((s) => s.prefix === storage.schema); | ||
| if (selectedSchema && selectedSchema.readOnly) { | ||
| storage.readOnly = true; | ||
| } |
There was a problem hiding this comment.
Is the idea to allow only read-only in every case? How do users change data there?
If that's the case, we should probably improve the UX because, with the current solution, we show a ticked read-only box that looks like an element users can interact with, but clicking doesn't do anything. I suggest:
- Making the readOnly input... "readOnly" -- sorry for the pun, I mean that the element
<input id="readonly [...] />should have something like<input id="readonly [...] readOnly={selectedSchema.readOnly ?? false} /> - Show a warning mentioning that there is no way to write with that external storage.
As I write these lines, I wonder why forcing the read-only flag here -- shouldn't that be down to the user's permissions? I assume some users can write.
| @@ -62,6 +62,11 @@ export const CLOUD_STORAGE_OVERRIDE = { | |||
| "WebDAV compatible services, including PolyBox and SwitchDrive", | |||
| position: 2, | |||
| }, | |||
| openbis: { | |||
There was a problem hiding this comment.
This warning is easy to address: you can add openbis to the array "skipWords" in the lining configuration in "client/.eslintrc.json"
|
@olloz26 Sorry for the delay; I'll review this soon. P.S. It would be great if you could resolve the conflicts |
|
@olloz26 any update on this? |
BREAKING CHANGE: requires changes in the renku-data-services and renku-notebooks repositories
olloz26
force-pushed
the
olloz26/connect-renkulab-and-openbis-datasets
branch
from
a6d93d4 to
5116b0e
Compare
olloz26
had a problem deploying
to
renku-ci-ui-3238
GitHub Actions
Failure
|
You can access the deployment of this PR at https://renku-ci-ui-3238.dev.renku.ch |
/deploy renku-data-services=pitch/add-documentation-to-projects