Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide the edit button when the user does not have permissions #3462

Merged
merged 10 commits into from
Jan 7, 2025

Conversation

leafty
Copy link
Member

@leafty leafty commented Dec 20, 2024

Closes #3446.

Update the actions buttons on the project / group / user pages to be presented only when the corresponding action is available to the user.

Project Page - Code Repositories

Can edit project
image

Cannot edit project
Screenshot 2024-12-20 at 11 44 48

Project Page - Sessions

Can edit project
image

Cannot edit project
image

Project Page - Data Connectors

Can edit data connector & Can edit project
image

Can edit data connector & Cannot edit project
Screenshot 2024-12-20 at 11 48 48

Cannot edit data connector & Can edit project
image

Cannot edit data connector & Cannot edit project
image

Anonymous user (cannot save credentials)
image

Group or User Page - Data Connectors

Can delete data connector (owner)
image

Can edit data connector
image

Cannot edit data connector
image

Anonymous user (cannot save credentials)
image

/deploy

@leafty leafty temporarily deployed to renku-ci-ui-3462 December 20, 2024 09:19 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3462.dev.renku.ch

@leafty leafty temporarily deployed to renku-ci-ui-3462 December 20, 2024 09:41 — with GitHub Actions Inactive
@leafty leafty force-pushed the leafty/fix-3446-edit-permissions branch from ec512b1 to f3a5a57 Compare December 20, 2024 12:39
@leafty leafty temporarily deployed to renku-ci-ui-3462 December 20, 2024 12:52 — with GitHub Actions Inactive
@leafty leafty marked this pull request as ready for review December 20, 2024 12:54
@leafty leafty requested a review from a team as a code owner December 20, 2024 12:54
@leafty leafty temporarily deployed to renku-ci-ui-3462 January 3, 2025 08:48 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3462 January 3, 2025 08:59 — with GitHub Actions Inactive
lorenzo-cavazzi
lorenzo-cavazzi previously approved these changes Jan 5, 2025
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! 🚀

@leafty leafty temporarily deployed to renku-ci-ui-3462 January 6, 2025 08:29 — with GitHub Actions Inactive
@leafty leafty requested a review from lorenzo-cavazzi January 6, 2025 08:38
lorenzo-cavazzi
lorenzo-cavazzi previously approved these changes Jan 7, 2025
@leafty leafty merged commit a75f163 into main Jan 7, 2025
18 of 19 checks passed
@leafty leafty deleted the leafty/fix-3446-edit-permissions branch January 7, 2025 10:24
@RenkuBot
Copy link
Contributor

RenkuBot commented Jan 7, 2025

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not show the edit buttons and the Settings tab in projects and groups
3 participants