Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show the edit buttons and the Settings tab in projects and groups #3446

Open
lorenzo-cavazzi opened this issue Dec 17, 2024 · 4 comments · May be fixed by #3462
Open

Do not show the edit buttons and the Settings tab in projects and groups #3446

lorenzo-cavazzi opened this issue Dec 17, 2024 · 4 comments · May be fixed by #3462

Comments

@lorenzo-cavazzi
Copy link
Member

lorenzo-cavazzi commented Dec 17, 2024

This is only sometimes consistent.

We should remove the buttons to add/modify resources on projects/groups. That includes:

  • Adding resources (repositories, data, sessions, ...)
  • Editing (info)
  • Settings page (redirect if needed) [EDIT: let the Settings section be visible to everyone]

--- EDIT ---

Places where we still show edit buttons despite no write access:

  • Project info box
  • Code repo listing
  • Maybe also data connectors - need to be checked
  • code repo side sheet top right edit button
  • data connector side sheet top right edit button
  • session launcher + environment side sheet buttons (top right, environment, and resource class)

Example - Code Repository:
image

@leafty
Copy link
Member

leafty commented Dec 18, 2024

What is the issue here? This does not seem to be a problem as described.

@lorenzo-cavazzi
Copy link
Member Author

@leafty The issue is that we sometimes show buttons for actions that users cannot do because they don't have privileges, and sometimes we don't. E.G. if you create a public project, we don't show the buttons to add a resource like data or code repositories, but we show a disabled button for editing the project info.
We want to keep the UX consistent across the application.

The product team's preference is to hide the buttons whenever there is no corresponding action that the users can do. E.G. on the project page, a non-privileged user can't add resources nor modify info/settings.

@leafty
Copy link
Member

leafty commented Dec 19, 2024

@lorenzo-cavazzi I have updated the issue after we have revised what was still not fully fleshed out. The plus buttons are correct on the project page, and the settings page needs to be shown to all users.

The remaining issue is that the "Edit" button appears on the offcanvas and on the code repository boxes.

@lorenzo-cavazzi
Copy link
Member Author

@leafty I appreciate your effort in adding more information to the issue, but please do not remove content from the initial post unless it has been discussed -- if you disagree with what's written, please bring it up here first either here or on slack. There have been previous discussions with the product team.

the settings page needs to be shown to all users.

Why? Many other platforms hide the settings to users without privileges (E.G: GitHub). If you disagree, feel free to bring that up with the product team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants