feat: cache amalthea sessions #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is part of the following stack: Change managed by git-spice. |
olevski
had a problem deploying
to
renku-ci-nb-1983
GitHub Actions
Failure
olevski
force-pushed
the
feat-add-amalthea-session-cache
branch
from
8835949 to
def99a7
Compare
olevski
had a problem deploying
to
renku-ci-nb-1983
GitHub Actions
Failure
Panaetius
previously approved these changes
Sep 18, 2024
olevski
force-pushed
the
feat-jupyter-free-sessions
branch
from
3e9cb0e to
7dc4049
Compare
olevski
force-pushed
the
feat-add-amalthea-session-cache
branch
from
def99a7 to
b13ad8c
Compare
olevski
had a problem deploying
to
renku-ci-nb-1983
GitHub Actions
Failure
leafty
previously approved these changes
Oct 2, 2024
k8s-watcher/server_routes.go
Outdated
Comment on lines
11
to
21
| s.router.HandlerFunc("GET", "/servers", s.jsGetAll) | ||
| s.router.HandlerFunc("GET", "/servers/:serverID", s.jsGetOne) | ||
| s.router.HandlerFunc("GET", "/users/:userID/servers", s.jsUserID) | ||
| s.router.HandlerFunc("GET", "/users/:userID/servers/:serverID", s.jsUserIDServerID) | ||
| s.router.HandlerFunc("GET", "/sessions", s.asGetAll) | ||
| s.router.HandlerFunc("GET", "/sessions/:serverID", s.asGetOne) | ||
| s.router.HandlerFunc("GET", "/users/:userID/sessions", s.asUserID) | ||
| s.router.HandlerFunc("GET", "/users/:userID/sessions/:serverID", s.asUserIDServerID) |
There was a problem hiding this comment.
Note: the routing scheme may be confusing 😅 .
There was a problem hiding this comment.
I agree. But I was thinking that we will purge the old notebooks endpoints soon and after that it will be better. I can add a comment to explain the difference between server/sessions.
There was a problem hiding this comment.
"Soon" will not be soon. Renku 1.0 will have to be supported for a long time still.
Adapts the k8s watcher to cache the new amalthea sessions CRD.
olevski
force-pushed
the
feat-add-amalthea-session-cache
branch
from
5cfdf84 to
5eba8e4
Compare
Co-authored-by: Flora Thiebaut <[email protected]>
olevski
force-pushed
the
feat-add-amalthea-session-cache
branch
from
5eba8e4 to
81dd32d
Compare
olevski
had a problem deploying
to
renku-ci-nb-1983
GitHub Actions
Failure
leafty
approved these changes
Oct 3, 2024
olevski
had a problem deploying
to
renku-ci-nb-1983
GitHub Actions
Failure
olevski
temporarily deployed
to
renku-ci-nb-1983
GitHub Actions
Inactive
|
You can access the deployment of this PR at https://renku-ci-nb-1983.dev.renku.ch |
|
This PR needed an update to the RBAC for the k8s watcher and notebooks. This has been done already and released. So the PR can be merged. This is the commit that added RBAC: SwissDataScienceCenter/renku@dfbb191 It has been released in renku 0.58.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapts the k8s watcher to cache the new amalthea sessions CRD.
/deploy