fix: scientific notation integer parsing in config #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panaetius
reviewed
Oct 11, 2023
| @@ -29,8 +26,8 @@ class Config: | |||
| git_proxy_health_port: Union[Text, int] = 8081 | |||
|
|
|||
| def __post_init__(self): | |||
| self.port = _parse_value_as_numeric(self.port, int) | |||
| self.git_proxy_health_port = _parse_value_as_numeric(self.git_proxy_health_port, int) | |||
| self.port = _parse_value_as_int(self.port) | |||
There was a problem hiding this comment.
question (non-blocking): Do ports actually have this issue, since they only go to 65535?
There was a problem hiding this comment.
Probably not but I am not sure at what value k8s decides to convert large ints to scientific notation
m-alisafaee
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helm will convert a large integer (specified normally in the values file) like
3000000to scientific notation like3e6in the templates.And python
int()crashes when it sees3e6and you have to usefloat()to parse it.Also I have the same function repeated because it is in two separate modules that are at the same level and they share no code. So to not repeat that one simple function I would have to do a lot unnecessary gymnastics just for one small really simple function.