feat: add disk storage to session launchers #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12478844553Details
💛 - Coveralls |
m-alisafaee
reviewed
Jan 7, 2025
| @@ -118,9 +119,11 @@ def validate_session_launcher_patch( | |||
| resource_class_id = RESET | |||
| else: | |||
| resource_class_id = patch.resource_class_id | |||
| disk_storage = RESET if "disk_storage" in data_dict and data_dict["disk_storage"] is None else patch.disk_storage | |||
There was a problem hiding this comment.
issue: What if we don't want to change the disk storage in the PATCH? If we don't set it, the value will be None and it causes the disk storage to be reset (in the followup code).
There was a problem hiding this comment.
A value of None does NOT reset the value during the patch operation.
| @@ -451,6 +455,7 @@ async def test_patch_session_launcher( | |||
| assert res.json.get("name") == patch_payload["name"] | |||
| assert res.json.get("description") == patch_payload["description"] | |||
| assert res.json.get("resource_class_id") == patch_payload["resource_class_id"] | |||
| assert res.json.get("disk_storage") == 3 | |||
There was a problem hiding this comment.
suggestion: We should add a test to check disk storage isn't modified if it isn't sent in the PATCH.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #589.
Add a new
disk_storagefield to session launchers so that a custom disk size can be persisted.Note: the disk storage size is not validated when saved.
See also: SwissDataScienceCenter/renku-ui#3463
Deployment: https://renku-ci-ui-3463.dev.renku.ch/