Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pin marshmallow dependency #87

Merged
merged 2 commits into from
Jan 8, 2025
Merged

fix: pin marshmallow dependency #87

merged 2 commits into from
Jan 8, 2025
+879 −806

Conversation

Panaetius
Copy link
Member

No description provided.

@Panaetius Panaetius requested a review from a team as a code owner January 7, 2025 10:01
@Panaetius Panaetius force-pushed the fix-marshmallow-dependency branch 4 times, most recently from 34892e6 to fb807e0 Compare January 7, 2025 13:11
@Panaetius Panaetius force-pushed the fix-marshmallow-dependency branch from 7e9a14c to e8f44c8 Compare January 7, 2025 14:19
@Panaetius Panaetius merged commit c59d6fe into master Jan 8, 2025
7 checks passed
@Panaetius Panaetius deleted the fix-marshmallow-dependency branch January 8, 2025 08:07
@sloria
Copy link

sloria commented Jan 9, 2025 •
edited
Loading

👋 marshmallow maintainer here. was searching for usages of SchemaABC which brought me to this repo. i think you can fix compatibility with marshmallow>=3.24.0 by replacing the import of SchemaABC here:

calamus/calamus/fields.py

Line 28 in c59d6fe

from marshmallow.base import SchemaABC

with

from marshmallow.schema import Schema

and replacing SchemaABC with Schema in the code

@Panaetius
Copy link
Member Author

Thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eikek eikek eikek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Panaetius @sloria @eikek @RenkuBot