Help prevent connection leaks and adoption of antipatterns by querying repo directly #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implication of this is that declare-pipeline and the `lein-grafter` plugin will be unsupported in the OSS grafter from 0.9.x. This code has moved into Swirrls internal grafter-server project.
From 0.9.0 onwards grafter/grafter will include only RDF processing code. Code that depends on grafter.tabular can include a new legacy dependency which can be found at: https://github.com/Swirrl/grafter.tabular Or includable with the clojars coordinates: [grafter/grafter.tabular "0.9.0"] ;; (check version)
now we no longer use lein-repack and have split grafter.tabular into its own repo
Amend release notes
Clients who receive this exception should adopt a pattern migrating
code from this:
(let [repo (repo)]
(query repo "select * where { ?s ?p ?o .} limit 10")
)
To something more like this:
(let [repo (repo)]
(with-open [conn (->connection repo)]
(doall (query conn "select * where { ?s ?p ?o . } limit 10"))))
We plan to add more eager APIs to assist with this in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109