Query/Write protocols should not be extended to Repository (only RepositoryConnection) #109
Comments
RickMoynihan
added a commit
that referenced
this issue
Jul 20, 2017
Clients who receive this exception should adopt a pattern migrating
code from this:
(let [repo (repo)]
(query repo "select * where { ?s ?p ?o .} limit 10")
)
To something more like this:
(let [repo (repo)]
(with-open [conn (->connection repo)]
(doall (query conn "select * where { ?s ?p ?o . } limit 10"))))
We plan to add more eager APIs to assist with this in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For convenience at a REPL we've always allowed you to call query etc on a Repository object directly. However doing so leaks a
RepositoryConnectionresource, which can cause serious and hard to find bugs in production.We should remove the extensions of these functions to Repository, and instead raise an error telling people to change to call the function on the result of
(->connection repo)notrepoitself, and wrap in awith-openThis has been a common bug in code, hopefully this will improve the situation; though we also need to encourage more eager processing of queries (See #104).
The text was updated successfully, but these errors were encountered: