-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation mode #346
base: master
Are you sure you want to change the base?
Validation mode #346
Conversation
35c7be0
to
ea2e101
Compare
ea2e101
to
5141199
Compare
5141199
to
34cbac1
Compare
In this mode we validate the data against the table schema and report any errors. No RDFization is done, and a return code is propogated upon a failure to the shell.
34cbac1
to
ceacad8
Compare
The current main outstanding issue is that for some failures it will output the failures several times.
|
Also: * ensure it is only printed once * add a couple of extra test cases
393e1eb
to
2212033
Compare
closes #342 |
closes #323 |
835c3d2
to
1ee3456
Compare
This looks good to me, though one thing I was wondering perhaps we could display better output in the case of a mismatched schema: I was thinking perhaps loading the column I'd be happy to try and improve this in a different isolated PR though, and create an issue for it; and just merge this PR though.
|
I couldn't find the example I'd used but recreated a different one: different-schema-columns-verbose-output-issue.zip
|
Add a new
--validate-data
mode which does not generate RDF, but does validate the tabular data against the CSVW TableSchema.The command line app will also exit with a non-zero exit code in this mode.
NOTE I tagged this PR and built some graal native binaries off it, which are downloadable from here:
https://github.com/Swirrl/csv2rdf/releases/tag/v0.6.1-validation-2
We may also want to test this with TableGroups, and check it works as we'd like in that case.