DX-2042: Ensure that includes are used where possible #1714
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, some effort has been made to create an RSpec which ensures that where we have includes, they are used. The spec works as following:
The spec mostly works, but needs tweaking to exclude false positives where there is a match on the field but the corresponding include is for a similarly named field in another request or response model. The creation of the GitHub code review also fails, due to the following error: