Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve locust-grafana scripts #199

Merged

Conversation

abakanovskii
Copy link
Contributor

Hi! Im using timescale graphs and just want to share my simple improvements for now:

  1. Fix end-of-line
  2. Add PGPASSWORD env variable to allow setting password automatically as in the current implementation you would need to enter grafana and then manually enter postgresql password
  3. Make create_datasource.sh script more human-readable and add $PGPASSWORD in a body

@cyberw
Copy link
Collaborator

cyberw commented Nov 18, 2024

Not sure what those linting errors are about, but do you think you can fix them?

@abakanovskii
Copy link
Contributor Author

Not sure what those linting errors are about, but do you think you can fix them?

Hmm, seems to be a max-args linting value issue, not sure why there were no errors before

@abakanovskii abakanovskii force-pushed the improve-timescale-grafana-scripts branch from 137bef2 to 00801f8 Compare November 18, 2024 21:03
@abakanovskii abakanovskii force-pushed the improve-timescale-grafana-scripts branch from 00801f8 to 7598670 Compare November 18, 2024 21:04
@cyberw cyberw merged commit f30c3db into SvenskaSpel:master Nov 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants