Experimental client performance improvement #1035
Open
+257
−603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chriz-G
reviewed
Dec 7, 2024
There was a problem hiding this comment.
While I agree using a dictionary is a good idea, you should also maintain the object list aswell. You should use the dictionary for lookups and the list for looping.. the current way you are looping the dictionary values is going to cause excessive heap allocation and GC will kick in later down the line.. on the arti client we maintain both list and dictionary
My own idea. Nothing to do with Chriz's stupid suggestion.
|
Is the syncing improvement due to the Skip frame now being > 0 instead of 1 or the Move time change in GameScene? |
Combination of both |
Causing huge memory heap allocations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would like a bit of testing on this before been merged. During my testing running 2 clients side by side and running up and down with 1 player both clients stayed quite well in sync