add escapePath utility function

[benmccann]

closes #29

I didn't copy any tests over yet as I thought it was worth deciding on a couple of other questions first before investing more time into it

I wasn't quite sure how to handle the license. This project is ISC licensed and fast-glob is MIT licensed. The two licenses are extremely similar, but I think it'd be simplest if they used the same license. Would you be okay with switch to the MIT license? If so, we should probably also confirm with the other contributors to this project, which luckily shouldn't be hard to do given that it's still a relatively new project

I just put everything into the index file for now since it's still relatively small, but would you prefer these to live in a separate file? I took a few liberties in making minor modifications to the fast-glob code to keep things simpler. E.g. I replaced their utils.string.isEmpty method with directly doing item !== '' so that there were fewer methods to copy over - and I also find it easier to read without the extra layer of indirection.

[pkg-pr-new]

Open in Stackblitz

pnpm add https://pkg.pr.new/tinyglobby@36

pnpm add https://pkg.pr.new/tinyglobby@36

commit: c9c2ee2

[SuperchupuDev]

the current status on utility functions from fast-glob (and why i haven't merged this yet) is that i think copying code over isn't ideal and hopefully we find a way to implement these functions in a different way (ideally more optimal?). haven't really looked much into it though. if you manage to reimplement it though, please let me know

[benmccann]

Yeah, that's a good call out. I've shrunk down the code dramatically now and removed probably 90% of the original. I think this is about as simple as it can get now

[SuperchupuDev]

interesting, i can notice there's something that could be improved: using a negative lookahead for the leading slash of the pattern, and removing the group names (we can always add them back later). also, .replaceAll was added in node 15, you'll have to use .replace with the global flag

[benmccann]

I made the .replace change

I'm super nervous about touching the regex as it's not my strong suit and they seem pretty fiddly. I think we can try to improve it a bit, but I'd like to add some tests first. Of course the easiest way to do that would just be to copy the tests from fast-glob, but I kind of want to figure out the licensing thing first. Do you think it would be okay to change the LICENSE to MIT? If so, I can ping the other contributors to see if they're okay with it

[benmccann]

Oh, I hadn't caught up on the Discord discussion yet. Looks like we're okay to proceed on that

[benmccann]

Okay, I removed the group names and copied over some tests

I'm still too nervous to mess with the regex anymore though. There's not a lot of tests and I've never used a negative lookahead before. I'm not too worried about performance because this is usually just called once or twice in a program's life, so doesn't need to be super optimized. If you still think we should tweak it then I might have to leave that last bit to you

[SuperchupuDev]

don't worry, i'll look into it

[SuperchupuDev]

using a negative lookbehind seems to work and be more efficient, as it won't match already escaped characters. will test some more though