Rewrite of Spiral SWT #304
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Two tests from Alin: (1) Canted AFM and (2) DM with single-ion anisotropy. There is no test on single-ion anisotropy because any small amount deforms the spiral phase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this new version, exchange is treated entirely in Fourier space, via construction of$J(q)$ .
The important new feature is that the propagation wavevector$k$ is categorized into one of three "special" cases via the new function $J(q)$ will vary according to case. This is required as a correctness fix for FM and AFM structures (interpreted as generalized spirals), which involve $q$ with integer and half-integer components, respectively.
spiral_propagation_case. The treatment of Fourier-space interactionsAfter some small cleanup, this is probably safe to merge. All tests pass, including new ones included in the PR. Also, performance seems roughly unchanged between new and old codes.
If this PR solves a high-priority problem for you, please let me know, and I'll be happy to focus on cleaning it up and merging.