Feature errors cleanup

.github/workflows/maven.yml

@@ -22,6 +22,12 @@ jobs:
         cache: 'maven'
     - name: Set up properties
       run: sh configure-dependencies.sh
+#   # debug step
+#    - name: Setup upterm session
+#      uses: lhotari/action-upterm@v1
+#      with:
+#        ## limits ssh access and adds the ssh public key for the user which triggered the workflow ie holashchand
+#        limit-access-to-actor: true
     - name: Build and test
       run: make test
 #  test:

Makefile

@@ -28,12 +28,10 @@ java/registry/target/registry.jar: $(SOURCES)
 	cd java && ./mvnw clean install
 
 test: build
-	@echo "VIEW_DIR=java/apitest/src/test/resources/views" >> .env || echo "no permission to append to file"
-	@echo "SCHEMA_DIR=java/apitest/src/test/resources/schemas" >> .env || echo "no permission to append to file"
 	@docker-compose down
 	@rm -rf db-data* || echo "no permission to delete"
 	# test with distributed definition manager and native search
-	@SEARCH_PROVIDER_NAME=dev.sunbirdrc.registry.service.NativeSearchService RELEASE_VERSION=latest KEYCLOAK_IMPORT_DIR=java/apitest/src/test/resources KEYCLOAK_SECRET=a52c5f4a-89fd-40b9-aea2-3f711f14c889 MANAGER_TYPE=DistributedDefinitionsManager DB_DIR=db-data-1 docker-compose up -d db keycloak registry certificate-signer certificate-api redis
+	@docker-compose --env-file test_environments/test1.env up -d db keycloak registry certificate-signer certificate-api redis
 	@echo "Starting the test" && sh build/wait_for_port.sh 8080
 	@echo "Starting the test" && sh build/wait_for_port.sh 8081
 	@docker-compose ps
@@ -42,7 +40,7 @@ test: build
 	@docker-compose down
 	@rm -rf db-data-1 || echo "no permission to delete"
 	# test with kafka(async), events, notifications,
-	@NOTIFICATION_ENABLED=true NOTIFICATION_URL=http://notification-ms:8765/notification-service/v1/notification TRACK_NOTIFICATIONS=true EVENT_ENABLED=true ASYNC_ENABLED=true RELEASE_VERSION=latest KEYCLOAK_IMPORT_DIR=java/apitest/src/test/resources KEYCLOAK_SECRET=a52c5f4a-89fd-40b9-aea2-3f711f14c889 DB_DIR=db-data-2 docker-compose up -d db clickhouse redis es keycloak registry certificate-signer certificate-api kafka zookeeper notification-ms metrics
+	@docker-compose --env-file test_environments/test2.env up -d db clickhouse redis es keycloak registry certificate-signer certificate-api kafka zookeeper notification-ms metrics
 	@echo "Starting the test" && sh build/wait_for_port.sh 8080
 	@echo "Starting the test" && sh build/wait_for_port.sh 8081
 	@docker-compose ps

build/wait_for_port.sh

@@ -4,7 +4,7 @@ echo "Waiting service to launch on $1..."
 i=0
 while ! curl localhost:$1; do
   sleep 10
-  let i=i+1
+  ((i=i+1))
   if [[ $i -gt 60 ]]; then
     echo "Failed to get the service in sane state!"
     exit 1;

deps/keycloak-mobile-number-login-spi/src/main/java/in/divoc/api/authenticator/NotifyService.java

@@ -1,7 +1,8 @@
 package in.divoc.api.authenticator;
 
-import okhttp3.*;
-import org.jboss.logging.Logger;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.io.BufferedReader;
 import java.io.IOException;
@@ -12,7 +13,7 @@
 import java.nio.charset.StandardCharsets;
 
 public class NotifyService {
-	private static final Logger logger = Logger.getLogger(NotifyService.class);
+	private static final Logger logger = LoggerFactory.getLogger(NotifyService.class);
 	private static final String notificationURL = System.getenv().getOrDefault("NOTIFICATION_SERVICE_URL", "http://localhost:8765/notification-service/v1/notification");
 	private static final String messageTemplate = System.getenv().getOrDefault("MESSAGE_TEMPLATE", "Your OTP to access SunbirdRC portal is %s. Please dont share this with anyone.");
 
@@ -44,7 +45,7 @@ public void notify(String to, String otp) throws IOException {
 				System.out.println(response.toString());
 			}
 		} catch (IOException e) {
-			logger.error(e);
+			logger.error("Exception occurred while notifying: {}", e.getMessage());
 		}
 
 	}

docker-compose.yml

@@ -2,7 +2,7 @@ version: "2.4"
 
 services:
   es:
-    image: docker.elastic.co/elasticsearch/elasticsearch:8.8.1
+    image: docker.elastic.co/elasticsearch/elasticsearch:7.17.13
     environment:
       - discovery.type=single-node
       - "ES_JAVA_OPTS=-Xms512m -Xmx512m"
@@ -40,6 +40,7 @@ services:
       - connectionInfo_uri=jdbc:postgresql://db:5432/registry
       - connectionInfo_username=postgres
       - connectionInfo_password=postgres
+      - encryption_enabled=${ENCRYPTION_ENABLED-false}
       - event_enabled=${EVENT_ENABLED-false}
       - event_topic=events
       - event_providerName=dev.sunbirdrc.registry.service.impl.KafkaEventService
@@ -54,15 +55,18 @@ services:
       - sunbird_sso_admin_client_id=${KEYCLOAK_ADMIN_CLIENT_ID-admin-api}
       - sunbird_sso_client_id=${KEYCLOAK_CLIENT_ID-registry-frontend}
       - sunbird_sso_admin_client_secret=${KEYCLOAK_SECRET}
+      - claims_enabled=${CLAIMS_ENABLED-false}
       - claims_url=http://claim-ms:8082
+      - signature_enabled=${SIGNATURE_ENABLED-false}
       - sign_url=http://certificate-signer:8079/sign
       - verify_url=http://certificate-signer:8079/verify
       - sign_health_check_url=http://certificate-signer:8079/health
-      - signature_enabled=true
+      - certificate_enabled=${CERTIFICATE_ENABLED-false}
       - pdf_url=http://certificate-api:8078/api/v1/certificatePDF
       - certificate_health_check_url=http://certificate-api:8078/health
       - template_base_url=http://registry:8081/api/v1/templates/ #Looks for certificate templates for pdf copy of the signed certificate
       - sunbird_keycloak_user_set_password=true
+      - filestorage_enabled=false
       - filestorage_connection_url=http://file-storage:9000
       - filestorage_access_key=admin
       - filestorage_secret_key=12345678
@@ -213,7 +217,7 @@ services:
       zookeeper:
         condition: service_started
     ports:
-      - "9092:9092"
+      - "9094:9094"
     environment:
       KAFKA_BROKER_ID: "1"
       KAFKA_ZOOKEEPER_CONNECT: "zookeeper:2181"
@@ -281,9 +285,15 @@ services:
       REDIS_URL: redis:6379
     ports:
       - "8070:8070"
+    healthcheck:
+      test:
+        [ "CMD-SHELL", "wget -nv -t1 --spider http://localhost:8070/health || exit 1" ]
+      interval: 30s
+      timeout: 10s
+      retries: 10
     depends_on:
       kafka:
-        condition: service_started
+        condition: service_healthy
       registry:
         condition: service_healthy
   redis:

java/.mvn/wrapper/MavenWrapperDownloader.java

@@ -89,7 +89,6 @@ public static void main(String args[]) {
             System.exit(0);
         } catch (Throwable e) {
             System.out.println("- Error downloading");
-            e.printStackTrace();
             System.exit(1);
         }
     }

java/claim/src/main/java/dev/sunbirdrc/claim/service/ClaimsAuthorizer.java

@@ -35,7 +35,7 @@ public boolean isAuthorizedAttestor(Claim claim, JsonNode attestorNode) {
             );
             return conditionResolverService.evaluate(resolvedCondition);
         } catch (Exception e) {
-            logger.error(e.getMessage());
+            logger.error("Exception occurred while resolving condition {}", e.getMessage());
             return false;
         }
     }

java/elastic-search/src/main/java/dev/sunbirdrc/elastic/ElasticServiceImpl.java

@@ -200,7 +200,7 @@ public RestStatus addEntity(String index, String entityId, JsonNode inputEntity)
             Map<String, Object> inputMap = JSONUtil.convertJsonNodeToMap(inputEntity);
             response = getClient(index).index(new IndexRequest(index, searchType, entityId).source(inputMap), RequestOptions.DEFAULT);
         } catch (IOException e) {
-            logger.error("Exception in adding record to ElasticSearch", e);
+            logger.error("Exception in adding record to ElasticSearch: {}", e.getMessage());
         }
         return response.status();
     }
@@ -242,7 +242,7 @@ public RestStatus updateEntity(String index, String osid, JsonNode inputEntity)
             logger.debug("updateEntity inputEntity {}", inputEntity);
             response = getClient(index.toLowerCase()).update(new UpdateRequest(index.toLowerCase(), searchType, osid).doc(inputMap), RequestOptions.DEFAULT);
         } catch (IOException e) {
-            logger.error("Exception in updating a record to ElasticSearch", e);
+            logger.error("Exception in updating a record to ElasticSearch: {}", e.getMessage());
         }
         return response.status();
     }
@@ -264,7 +264,7 @@ public RestStatus deleteEntity(String index, String osid) {
             readMap.put(Constants.STATUS_KEYWORD, Constants.STATUS_INACTIVE);
             response = getClient(indexL).update(new UpdateRequest(indexL, searchType, osid).doc(readMap), RequestOptions.DEFAULT);
         } catch (NullPointerException | IOException e) {
-            logger.error("exception in deleteEntity {}", e);
+            logger.error("exception in deleteEntity {}", e.getMessage());
             return RestStatus.NOT_FOUND;
         }
         return response.status();
@@ -308,7 +308,7 @@ public ComponentHealthInfo getHealthInfo() {
             ClusterHealthResponse health = getClient("schema").cluster().health(request, RequestOptions.DEFAULT);
             return new ComponentHealthInfo(getServiceName(), Arrays.asList("yellow", "green").contains(health.getStatus().name().toLowerCase()), "", "");
         } catch (IOException e) {
-            logger.error("Elastic health status", e);
+            logger.error("Elastic health status {}", e.getMessage());
             return new ComponentHealthInfo(getServiceName(), false, CONNECTION_FAILURE, e.getMessage());
         }
     }

java/middleware-commons/src/test/java/dev/sunbirdrc/registry/middleware/service/ConditionResolverServiceTest.java

@@ -3,6 +3,8 @@
 import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.io.IOException;
 import java.util.ArrayList;
@@ -11,6 +13,7 @@
 import static org.junit.Assert.*;
 
 public class ConditionResolverServiceTest {
+    private static final Logger logger = LoggerFactory.getLogger(ConditionResolverServiceTest.class);
     ConditionResolverService conditionResolverService = new ConditionResolverService();
     @Test
     public void shouldAbleToResolveRequesterPaths() throws IOException {
@@ -44,7 +47,7 @@ public void shouldReturnTrueForValidExpression() throws IOException {
         try {
             resolve = conditionResolverService.resolve(getStudentJsonNode(), requester, condition, attributes);
         } catch (IOException e) {
-            e.printStackTrace();
+            logger.info("Exception occurred: {}", e.getMessage());
         }
         String attestor = "ATTESTOR";
         resolve = conditionResolverService.resolve(getTeacherJsonNode(), attestor, resolve, attributes);

java/middleware-commons/src/test/java/dev/sunbirdrc/registry/middleware/util/JSONUtilTest.java

@@ -6,6 +6,8 @@
 import com.fasterxml.jackson.databind.node.ObjectNode;
 import dev.sunbirdrc.pojos.AuditRecord;
 import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.io.*;
 import java.nio.charset.StandardCharsets;
@@ -15,6 +17,7 @@
 import static org.junit.Assert.*;
 
 public class JSONUtilTest {
+    private static final Logger logger = LoggerFactory.getLogger(JSONUtilTest.class);
     private static final String TEST_DIR = "src/test/resources/";
     private static final String ACTUAL_DATA = "actual_data.json";
     private static final String EXPECTED_DATA = "expected_data.json";
@@ -131,12 +134,8 @@ private String getContent(String fileName) {
             }
             return result.toString(StandardCharsets.UTF_8.name());
 
-        } catch (FileNotFoundException e1) {
-            e1.printStackTrace();
-
         } catch (IOException e) {
-            e.printStackTrace();
-
+            logger.info("Exception occurred: {}", e.getMessage());
         }
         return null;
     }

java/middleware/registry-middleware/keycloak/src/main/java/dev/sunbirdrc/keycloak/KeycloakAdminUtil.java

@@ -19,6 +19,7 @@
 import org.springframework.stereotype.Component;
 
 import java.util.*;
+import javax.ws.rs.NotFoundException;
 import javax.ws.rs.core.Response;
 
 import static dev.sunbirdrc.registry.middleware.util.Constants.CONNECTION_FAILURE;
@@ -130,6 +131,9 @@ private String createOrUpdateRealmGroup(String entityName) {
     private RoleRepresentation createOrGetRealmRole(String entityName) {
         RolesResource rolesResource = keycloak.realm(realm).roles();
         try {
+             return rolesResource.get(entityName).toRepresentation();
+        } catch (NotFoundException ex) {
+            logger.error("Role {} not found. Creating role {}", entityName, entityName);
             RoleRepresentation roleRepresentation = new RoleRepresentation();
             roleRepresentation.setName(entityName);
             rolesResource.create(roleRepresentation);

java/plugins/divoc-external-plugin/src/main/java/dev/sunbirdrc/plugin/services/DivocServices.java

@@ -70,8 +70,7 @@ public String fetchClientToken() {
 		try {
 			response = restTemplateProvider.exchange(divocKeycloakUrl, HttpMethod.POST, entity, Map.class);
 		} catch (HttpClientErrorException | HttpServerErrorException exception) {
-			LOGGER.error("Fetching divoc token failed: ");
-			exception.printStackTrace();
+			LOGGER.error("Fetching divoc token failed: {}", exception.getMessage());
 		}
 		if (response != null && response.getBody() != null && response.getBody().containsKey(ACCESS_TOKEN)) {
 			LOGGER.info("Divoc token fetch successfully.");
@@ -94,8 +93,7 @@ public byte[] fetchDivocPdf(String clientToken, String preEnrollmentCode, String
 			response = restTemplateProvider.exchange(divocUrl, HttpMethod.POST, entity, byte[].class);
 			return response.getBody();
 		} catch (HttpClientErrorException | HttpServerErrorException exception) {
-			LOGGER.error("Fetching divoc PDF failed: ", exception);
-			exception.printStackTrace();
+			LOGGER.error("Fetching divoc PDF failed: {}", exception.getMessage());
 		}
 		return null;
 	}

java/plugins/mosip-external-plugin/src/main/java/dev/sunbirdrc/plugin/controller/MosipCallbackController.java

@@ -69,7 +69,7 @@ public ResponseEntity callbackHandler(@RequestHeader Map<String, String> headers
                 return ResponseEntity.status(HttpStatus.INTERNAL_SERVER_ERROR).body(queryParams.get(Constants.HUB_CHALLENGE));
             }
         } catch (Exception e) {
-            LOGGER.error("Failed fetching mosip pdf", e);
+            LOGGER.error("Failed fetching mosip pdf: {}", e.getMessage());
             return ResponseEntity.status(HttpStatus.INTERNAL_SERVER_ERROR).body(queryParams.get(Constants.HUB_CHALLENGE));
         }
     }

java/plugins/mosip-external-plugin/src/main/java/dev/sunbirdrc/plugin/services/MosipAuthService.java

@@ -52,8 +52,7 @@ public HttpHeaders getAuthTokenHeader() {
         try {
             response = restTemplateProvider.exchange(webSubHubUrl + Constants.AUTH_URL, HttpMethod.POST, entity, String.class);
         } catch (HttpClientErrorException | HttpServerErrorException exception) {
-            LOGGER.error("Get auth token failed: ");
-            exception.printStackTrace();
+            LOGGER.error("Get auth token failed: {}", exception.getMessage());
         }
         if (response != null && response.getStatusCode() == HttpStatus.OK) {
             LOGGER.info("Successfully authenticated with mosip");

java/plugins/mosip-external-plugin/src/main/java/dev/sunbirdrc/plugin/services/MosipServices.java

@@ -80,8 +80,7 @@ void subscribeForPrintServiceEvents() {
         try {
             response = restTemplateProvider.exchange(webSubHubUrl + Constants.SUBSCRIBE_URL, HttpMethod.POST, entity, String.class);
         } catch (HttpClientErrorException | HttpServerErrorException exception) {
-            LOGGER.error("Subscription to topic failed: ");
-            exception.printStackTrace();
+            LOGGER.error("Subscription to topic failed: {}", exception.getMessage());
         }
         if (response != null && response.getStatusCode() == HttpStatus.ACCEPTED) {
             LOGGER.info("subscribed for topic {} at hub", topic);
@@ -104,8 +103,7 @@ private void registerTopic() {
         try {
             response = restTemplateProvider.exchange(webSubHubUrl + Constants.REGISTER_URL, HttpMethod.POST, entity, String.class);
         } catch (HttpClientErrorException | HttpServerErrorException exception) {
-            LOGGER.error("Register topic failed: ");
-            exception.printStackTrace();
+            LOGGER.error("Register topic failed: {}", exception.getMessage());
         }
         if (response != null && response.getStatusCode() == HttpStatus.ACCEPTED) {
             LOGGER.info("topic {} registered at hub", topic);
@@ -132,8 +130,7 @@ public Object generateOTP(SendOTPDto otpDto) {
         try {
             response = restTemplateProvider.exchange(webSubHubUrl + Constants.OTP_URL, HttpMethod.POST, entity, Object.class);
         } catch (HttpClientErrorException | HttpServerErrorException exception) {
-            LOGGER.error("Generate otp failed failed: ");
-            exception.printStackTrace();
+            LOGGER.error("Generate otp failed failed: {}", exception.getMessage());
         }
         if (response != null && response.getStatusCode() == HttpStatus.OK) {
             LOGGER.info("Successfully generated otp");
@@ -176,8 +173,7 @@ public Object fetchCredentials(FetchCredentialsDto fetchCredentialsDto) {
         try {
             response = restTemplateProvider.exchange(webSubHubUrl + Constants.CREDENTIALS_URL, HttpMethod.POST, entity, Object.class);
         } catch (HttpClientErrorException | HttpServerErrorException exception) {
-            LOGGER.error("Generate credentials failed failed: ");
-            exception.printStackTrace();
+            LOGGER.error("Generate credentials failed failed: {}", exception.getMessage());
         }
         if (response != null && response.getStatusCode() == HttpStatus.OK) {
             LOGGER.info("Successfully generated credentials");
@@ -200,8 +196,7 @@ public byte[] fetchMosipPdf(Map<String, String> requestHeaders, String requestBo
             response = restTemplateProvider.exchange(printUrl + Constants.PRINT_PDF_URL, HttpMethod.POST, entity, byte[].class);
             return response.getBody();
         } catch (HttpClientErrorException | HttpServerErrorException exception) {
-            LOGGER.error("Failed fetching pdf failed: ");
-            exception.printStackTrace();
+            LOGGER.error("Failed fetching pdf failed: {}", exception.getMessage());
         }
         LOGGER.error("Failed fetching pdf failed: ");
         return null;

java/pojos/src/main/java/dev/sunbirdrc/pojos/APIMessage.java

@@ -38,11 +38,13 @@ public APIMessage(HttpServletRequest servletRequest) {
 		request = new Request();
 		requestWrapper = new RequestWrapper(servletRequest);
 		String body = requestWrapper.getBody();
-		try {
-			request = new ObjectMapper().readValue(body, Request.class);
-		} catch (IOException jpe) {
-			logger.error("Can't read request body", jpe);
-			request = null;
+		if(body != null && !body.isEmpty()) {
+			try {
+				request = new ObjectMapper().readValue(body, Request.class);
+			} catch (IOException jpe) {
+				logger.error("Can't read request body: {}", jpe.getMessage());
+				request = null;
+			}
 		}
 	}
 

java/pojos/src/main/java/dev/sunbirdrc/pojos/ResponseWrapper.java

@@ -42,13 +42,13 @@ public void writeResponseBody(String content) {
 				bufferedWriter.write(content);
 			}
 		} catch (Exception ex) {
-			logger.error("ERROR IN SENDING RESPONSE:", ex);
+			logger.error("ERROR IN SENDING RESPONSE: {}", ex.getMessage());
 		} finally {
 			if (bufferedWriter != null) {
 				try {
 					bufferedWriter.close();
 				} catch (Exception ex) {
-					logger.error("ERROR in closing stream", ex);
+					logger.error("ERROR in closing stream: {}", ex.getMessage());
 				}
 			}
 		}