Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature errors cleanup #248

Merged
merged 28 commits into from
Sep 15, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
861ad8e
fixed file storage errors
holashchand Sep 4, 2023
ea2eaa9
added missing exception class file
holashchand Sep 4, 2023
189c0f2
fixed tests failure
holashchand Sep 4, 2023
222c5a3
fixed elastic search issues
holashchand Sep 4, 2023
16799e5
fixed signing and certificate service logs
holashchand Sep 4, 2023
fa87187
fixed errors for audit, notification, encryption, swagger, Api Messag…
holashchand Sep 5, 2023
9f2c1ee
fixed registry helper tests failing
holashchand Sep 6, 2023
17c824a
enabling certificate and claims only when enabled
holashchand Sep 6, 2023
920da2d
fixed make tests failing
holashchand Sep 7, 2023
bb02f4f
added health check to metrics service and fixed metrics service issues
holashchand Sep 8, 2023
2fc87d3
added missing metrics files
holashchand Sep 8, 2023
abf6d03
fixed error messages
holashchand Sep 8, 2023
d391071
minor fix
holashchand Sep 11, 2023
99b4d15
fixed certificate api docker file
holashchand Sep 11, 2023
a516175
added debug plugin
holashchand Sep 11, 2023
bb1d82a
added public key
holashchand Sep 11, 2023
33b074a
added manual workflow
holashchand Sep 11, 2023
33411eb
suppressing exception while loading schema from db
holashchand Sep 11, 2023
263d211
fixed elastic search version and removed debug config
holashchand Sep 12, 2023
c4a3453
fixed error messages
holashchand Sep 12, 2023
78c9c8b
fixed error messages
holashchand Sep 12, 2023
03145c7
change error messages to print stack
holashchand Sep 12, 2023
9c6dc53
changed kafka port exposing to 9092
holashchand Sep 13, 2023
5d186fd
fixed error messages, failing tests and renamed test environments
holashchand Sep 14, 2023
488bdef
throwing notify exception
holashchand Sep 14, 2023
65eb66c
reverted from error messages to stack trace
holashchand Sep 14, 2023
ffbfcda
fixed error messages for golang
holashchand Sep 15, 2023
43f260d
adding ensure index at startup back
holashchand Sep 15, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,5 @@ public void run(ApplicationArguments args) throws Exception {
logger.info("On Boot starts loading: parent vertex and shard records");
entityParenter.ensureKnownParenters();
entityParenter.loadDefinitionIndex();
entityParenter.ensureIndexExists();
holashchand marked this conversation as resolved.
Show resolved Hide resolved
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,16 @@
import java.io.IOException;
import java.io.InputStream;
import java.nio.charset.StandardCharsets;

import org.apache.commons.lang3.exception.ExceptionUtils;
import org.junit.Test;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

public class ViewTransformerTest {

private static final Logger logger = LoggerFactory.getLogger(ViewTransformerTest.class);

private ViewTransformer transformer = new ViewTransformer();

@Test
Expand Down Expand Up @@ -73,10 +79,9 @@ private static String readFileContent(String fileName) {
}
return result.toString(StandardCharsets.UTF_8.name());

} catch (FileNotFoundException e1) {
e1.printStackTrace();

} catch (IOException e) {}
} catch (IOException e) {
logger.error(ExceptionUtils.getStackTrace(e));
}
return null;
}

Expand Down
6 changes: 3 additions & 3 deletions scripts/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ var invoke_add = function (nIter, payload, callback) {
var apiResponse = JSON.parse(body)
if (err) {
console.error(err?.message)
console.log(" error for " + payload)
console.error(" error for " + payload)
callback(err)
} else {
var responseErr = apiResponse
Expand Down Expand Up @@ -237,7 +237,7 @@ var execute_tasks = function (tasks, fileName, cb) {
console.log("Executed tasks")
cb(null)
} else {
console.error(err?.message)
console.error(err)
console.log("One or more errors occurred.")
cb(err)
}
Expand Down Expand Up @@ -292,7 +292,7 @@ function populateData(cb) {
populateData(function (err, result) {
if (err) {
return (err);
console.log("Errorrrrr==>", err);
console.error("Errorrrrr==>", err);
}
console.log("Finished successfully");
return result;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ async function createPDF(certificate) {
return pdfBuffer
} catch (err) {
console.log("Failed while creating pdf")
console.log(err?.message)
console.log(err)
}
}

Expand Down
2 changes: 1 addition & 1 deletion services/certificate-signer/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const server = http.createServer(async (req, res) => {
}
console.timeEnd(req.url)
} catch (e) {
console.error(e?.message)
console.error(e)
res.statusCode = e["code"] || 500;
res.end(`{"error": "${http.STATUS_CODES[res.statusCode]}", "message": ${e.message}}`)
}
Expand Down
4 changes: 2 additions & 2 deletions services/metrics/cron/cron.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,13 @@ func (cron *Cron) SaveWeeklyMetrics() {
aggregate := (*cron.db).GetAggregates(clauses)
bytes, err := json.Marshal(aggregate)
if err != nil {
log.Infof("Error in marshalling : %v", err)
log.Errorf("Error in marshalling : %v", err)
}
ctx := context.Background()
log.Infof(string(bytes))
err = cron.redisClient.Set(ctx, "weeklyUpdates", string(bytes), 0).Err()
if err != nil {
log.Infof("Error in saving to redis : %v", err)
log.Errorf("Error in saving to redis : %v", err)
}
log.Info("Saved to redis")
}
Expand Down
3 changes: 1 addition & 2 deletions services/metrics/swagger_gen/restapi/server.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions services/notification-service/pkg/services/sms_service.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,7 @@ func GetSmsRequestPayload(message string, mobileNumber string) map[string]interf
log.Infof("success")
return smsRequest
} else {
log.Infof("error")
log.Error(err)
log.Errorf("error: %v", err)
}
log.Infof("error")
return nil
}
2 changes: 1 addition & 1 deletion services/public-key-service/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const server = http.createServer(async (req, res) => {

console.timeEnd(req.url)
} catch (e) {
console.error(e?.message)
console.error(e)
res.statusCode = e["code"] || 500;
res.end(`{"error": "${http.STATUS_CODES[res.statusCode]}", "message": ${e.message}}`)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export const VerifyCertificate = () => {
}
};
const handleError = err => {
console.error(err?.message)
console.error(err)
};
return (
<div className="container-fluid verify-certificate-wrapper">
Expand Down
Loading