Water Park experience improvements #2132
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tornac1234
commented
Apr 29, 2024
•
tornac1234
commented
- Fix spawning in "walk mode" in a water park
- Fix fishes broadcasting global coordinates while in water parks
- Sync creature hatching
- Sync creature mating
- Fix simulation ownership not being given when first placing buildings
- Fix some creature respawner having a cell level 100 (not handled by server)
tornac1234
added
Type: bug
Area: bases
|
Ready for review 😎 (and to be tested 🎮) |
Jannify
requested changes
May 15, 2024
NitroxClient/GameLogic/Spawning/WorldEntities/GlobalRootEntitySpawner.cs
Show resolved
Hide resolved
NitroxClient/GameLogic/Spawning/WorldEntities/GlobalRootEntitySpawner.cs
Show resolved
Hide resolved
Coding-Hen
reviewed
Nov 14, 2024
Comment on lines
+21
to
+22
| } | ||
| public EggMetadata(float timeStartHatching, float progress) |
There was a problem hiding this comment.
Suggested change
| } | |
| public EggMetadata(float timeStartHatching, float progress) | |
| } | |
| public EggMetadata(float timeStartHatching, float progress) |
| /// </summary> | ||
| public sealed partial class CreatureEgg_Hatch_Patch : NitroxPatch, IDynamicPatch | ||
| { | ||
| public static readonly MethodInfo TARGET_METHOD = Reflect.Method((CreatureEgg t) => t.Hatch()); |
There was a problem hiding this comment.
I'm assuming we don't need to deal with telling the other clients that it has hatched as this will be dealt with by the metadata processor/ async born patch below and we won't cause a race condition by sending the destroyed entity first?
|
note for myself: I've already started working on the reviews (and changed a thing or 2) in my stashes (a long time ago 💀 ) |
…emporary), fix crabsnake callback not working
…pieces (water parks, reactors ...)
tornac1234
force-pushed
the
waterparks-overall-sync
branch
from
247060e to
3d51e74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.