Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor:InstructorUI] Remove driver.get(current url) #31

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

powe97
Copy link
Contributor

@powe97 powe97 commented Aug 7, 2024

In getStudentInfoFromCourseHelper, the photo scraper currently has the following line:

        img_url = driver.current_url
        driver.get(img_url)

img_url is used nowhere else in the function, so it appears that this statement doesn't do anything, and probably slows down the scraper a little by running an unnecessary Selenium command.

@bmcutler bmcutler changed the title [Refactor:Photoscraper] Remove driver.get(current url) [Refactor:Instructor] Remove driver.get(current url) Aug 15, 2024
@bmcutler bmcutler changed the title [Refactor:Instructor] Remove driver.get(current url) [Refactor:InstructorUI] Remove driver.get(current url) Aug 15, 2024
@bmcutler bmcutler merged commit 7934520 into main Aug 15, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants