[WIP] Add filters to course search #2378

hannesmcman · 2018-02-22T19:37:47Z

Resolves #2342.

Desired filters:

hannesmcman · 2018-02-22T19:41:49Z

Here are some screenshots...I reused the filter-view component and most of the filter logic from the menus component..idk how I feel about the filtered terms showing up in the filter toolbar like that, especially when you filter by more than two, but that was the first idea that came to mind when I was thinking of what would be appropriate there..very open to dissent/other ideas!

•	•

hannesmcman · 2018-02-22T19:48:35Z

I can also move the rest of the course search redux stuff into the course-search part in this PR... @hawkrives I know you mentioned wanting that to happen.

hawkrives · 2018-02-22T20:05:32Z

Oh, I do like showing a summary of the selected filters in the filter space. That's a great idea!

I'm sure we can come up with a way to represent them compactly – 18/19:Spr/Int, 19/20:All, maybe?

hawkrives

Wow! Nice work.

hawkrives · 2018-02-22T20:06:48Z

source/lib/course-search/index.js

@@ -4,3 +4,4 @@ export {loadCachedCourses} from './load-cached-courses'
 export {updateStoredCourses, areAnyTermsCached} from './update-course-storage'
 export {CourseType, TermType} from './types'
 export {parseTerm} from './parse-term'
+export {loadGEs} from './load-ges'


Where is this called?

Looks to have been introduced in d2fdcdb#diff-df4b353eb39c9a68e6b0e3127a055bb4R69
and removed in da79336#diff-df4b353eb39c9a68e6b0e3127a055bb4L69

Yeah that was left over from my first attempt when I wasn't reusing the filter component..I kept it so that I could ask this question: For access to the acceptable list of GEs, departments, etc. should we load that data from the server and store it just like the course data, or should we try to somehow extract them from the course data itself? @hawkrives

I'd recommend using https://github.com/StoDevX/course-data/blob/gh-pages/data-lists/valid_gereqs.json for a list of GE requirements.

It's generated automatically from the course data every night.

Of, you can do something to determine the gereqs from the downloaded course data; that's what I do in Gobbldygook, too.

That's what it uses currently.

hawkrives · 2018-02-22T20:08:11Z

source/views/components/filter/types.js

@@ -6,7 +6,8 @@ export type ToggleSpecType = {
 }

 export type ListItemSpecType = {|
-	title: string,
+	title: string | number,
+	label?: string,


I'm not entirely clear on the difference between these two – can you summarize for me, please?

Looks like it comes down to:

title: term.term, label: parseTerm(term.term.toString()),

term would be a string or a number

label is data massaged out of parseTerm which lives in lib/course-search/parse-term.js where it returns the human readable term name (Abroad current / next year, Fall current / next year, etc)

Yep! I changed the spec type so that the applyFilters() function would work when the value of the key item specified isn't a string. The label allows the filter options to be displayed as "Fall 2016/17" instead of 20171, for example.

hannesmcman · 2018-02-22T22:17:59Z

@hawkrives re:summary of selected filters
Right now I have it so that this summary is cut off at one line: yay or nay?

hannesmcman · 2018-02-22T22:24:53Z

@hawkrives Ok so I got a filter up and running for "Open Courses," and realized that there are a whole bunch of courses listed as "Open" from past semesters...is this something that you want to fix for the course-data on the server itself or should that logic go in AAO?

hawkrives · 2018-02-22T22:29:54Z

@hannesmcman Those courses are technically still "open", as far as SIS / the registrar are concerned.

I don't know that we want to change that?

I'd still question how useful an open/closed filter would be. I never ran into a situation where it was a useful distinction to me as a student, AFAIR?

drewvolz · 2018-02-22T22:31:02Z

I say we shouldn't return past semester courses that are listed as open on the app's end.

hawkrives · 2018-02-22T22:31:34Z

I say we shouldn't care about "open/closed" at all :p

drewvolz · 2018-02-22T22:31:49Z

...and I see plenty of use for an open/closed filter for those trying to find open sections.

hawkrives · 2018-02-22T22:32:40Z

I don't even know when a section gets "closed". I don't remember seeing any that were closed in anything that I wanted to take (cough CS /cough), even when they were full.

drewvolz · 2018-02-22T22:34:45Z

I don't remember seeing any that were closed in anything that I wanted to take (cough CS /cough), even when they were full.

I was kicked out of a section that had closed during registration and had to find another section that was open

stodevx-bot · 2018-02-23T23:27:05Z

	Warnings
⚠️	Big PR! We like to try and keep PRs under 400 lines, and this one was 439 lines. If the PR contains multiple logical changes, splitting each change into a separate PR will allow a faster, easier, and more thorough review.

New dependencies added: p-props.

p-props

Author: Sindre Sorhus

Description: Like `Promise.all()` but for `Map` and `Object`

Homepage: https://github.com/sindresorhus/p-props#readme


Created	over 1 year ago
Last Updated	4 months ago
License	MIT
Maintainers	1
Releases	2
Keywords	promise, props, map, object, values, obj, properties, entries, async, await, promises, concurrently, concurrency, parallel and bluebird

README

p-props

Like Promise.all() but for Map and Object

Useful when you need to run multiple promises concurrently and keep track of the fulfilled values by name.

Install

$ npm install p-props

Usage

const pProps = require('p-props');
const got = require('got');

const fetch = url => got(url).then(res => res.body);

const sites = {
	ava: fetch('ava.li'),
	todomvc: fetch('todomvc.com'),
	github: fetch('github.com'),
	foo: 'bar'
};

pProps(sites).then(result => {
	console.log(result);
	//=> {ava: '<!doctype ...', todomvc: '<!doctype ...', github: '<!doctype ...', foo: 'bar'}
});

API

pProps(input)

Returns a Promise that is fulfilled when all promises in input are fulfilled, or rejects if any of the promises reject. The fulfilled value is the same as input, but with a fulfilled version of each entry value.

input

Type: Map Object

Resolves entry values that are promises. Other values are passed through.

License

MIT © Sindre Sorhus

Generated by 🚫 dangerJS

hawkrives · 2018-02-24T00:25:18Z

package.json

@@ -92,6 +92,7 @@
    "@hawkrives/react-native-alphabetlistview": "1.0.0",
    "@hawkrives/react-native-alternate-icons": "0.4.7",
    "@hawkrives/react-native-sortable-list": "1.0.1",
+    "bluebird": "3.5.1",


Can you use https://www.npmjs.com/package/p-props instead, please? It's a more focused dependency.

drewvolz · 2018-03-07T02:27:33Z

source/views/sis/course-search/lib/format-terms.js

+		case '9':
+			return {year: `${currentYearAbbrev}/${nextYear}`, semester: 'Non-Sto'}
+		default:
+			return {year: `${currentYearAbbrev}/${nextYear}`, semester: 'Unk'}


N/A might work well here. @StoDevX/all-about-olaf anyone have an opinion?

outdated

* master: (43 commits) chore(package): update lockfile fix(package): update react-native-network-info to version 3.1.0 update babel-jest to 22.4.1 update react-native-device-info to 0.17.3 run prettier update prettier to 1.11.1 chore(package): update lockfile chore(package): update js-yaml to version 3.11.0 chore(package): update lockfile chore(package): update ajv to version 6.2.1 chore(package): update lockfile fix(package): update moment to version 2.21.0 chore(package): update lockfile chore(package): update eslint to version 4.18.2 fix indentation make hawken happy and bring back cell Add url parsing back to helper for android to use Remove duplicate style Bundle Update on 2018-03-02 Replace org detail meetings, description, and site texts with TextInput ...

buildsize · 2018-03-07T03:39:25Z

This change will decrease the build size from 52.32 MB to 18.65 MB, a decrease of 33.67 MB (181%)

File name	Previous Size	New Size	Change
app-release-unsigned.apk	10.93 MB	[deleted]
output.json	267 bytes	[deleted]
breaks.json.gz	595 bytes	[deleted]
building-hours.json.gz	2.42 KB	[deleted]
bus-times.json.gz	1.97 KB	[deleted]
chapel.json.gz	135 bytes	[deleted]
contact-info.json.gz	2.34 KB	[deleted]
credits.json.gz	577 bytes	[deleted]
dictionary.json.gz	19.9 KB	[deleted]
faqs.json.gz	298 bytes	[deleted]
help.json.gz	1.37 KB	[deleted]
legal.json.gz	833 bytes	[deleted]
news-styles.css	537 bytes	[deleted]
news-styles.json.gz	334 bytes	[deleted]
pause-menu.json.gz	1.45 KB	[deleted]
privacy.json.gz	2.99 KB	[deleted]
transportation.json.gz	819 bytes	[deleted]
webcams.json.gz	552 bytes	[deleted]
breaks.json	1.56 KB	[deleted]
building-hours.json	24.15 KB	[deleted]
bus-times.json	7.29 KB	[deleted]
chapel.json	184 bytes	[deleted]
contact-info.json	8.36 KB	[deleted]
credits.json	930 bytes	[deleted]
dictionary.json	55.94 KB	[deleted]
faqs.json	414 bytes	[deleted]
help.json	2.8 KB	[deleted]
legal.json	1.42 KB	[deleted]
news-styles.json	604 bytes	[deleted]
pause-menu.json	5.39 KB	[deleted]
privacy.json	7.09 KB	[deleted]
transportation.json	2.11 KB	[deleted]
webcams.json	1.78 KB	[deleted]
ios.jsbundle	1.97 MB	[deleted]
ios.jsbundle.map	6.47 MB	[deleted]
AllAboutOlaf.app.dSYM.zip	1.1 MB	1.1 MB	-8 bytes (0%)
AllAboutOlaf.ipa	17.54 MB	17.55 MB	2.09 KB (0%)
android.jsbundle	4.98 MB	[deleted]
android.jsbundle.map	9.18 MB	[deleted]

hawkrives · 2018-03-07T05:16:23Z

I did a fair amount of reading on Flow's "disjoint union types" tonight, trying to figure out what was going on, but I think it's actually this bug, instead: Refine array types using filter.

So, what I did – and I only did this because this is an exceptional case; we want to avoid any as much as possible, because flow can't check it – is to define a set of functions for filtering an array for just a specific type of spec.

export function filterListSpecs(specs: Array<FilterType>): Array<ListType> {
	const retval = specs.filter(f => f.type === 'list')
	return ((retval: any): Array<ListType>)
}

I filter the array, with hopefully bug-free code, then I apply a typecast to the result to tell Flow exactly what we're returning.

stodevx-bot · 2018-03-07T05:23:14Z

iOS Report

Analysis of slow build times (>20s)

1m 27s: AllAboutOlaf/AllAboutOlaf [Release]
  1m 10s: Running script 'Bundle React Native code and images'
0m 27s: React/double-conversion [Release]
  0m 25s: Running script 'Install Third Party'
0m 12s: Bugsnag/BugsnagStatic [Release]
0m 15s: React/third-party [Release]
1m 09s: React/React [Release]
0m 31s: React/cxxreact [Release]

Generated by 🚫 dangerJS

hannesmcman added 15 commits February 5, 2018 21:14

preliminary work on filter view

9256814

filtering working for gereqs

d2fdcdb

Merge branch 'add-course-search' into add-filters

c22190f

add menu icon

7cede82

Merge branch 'add-course-search' into add-filters

ba48a7f

Updated filter toolbar to match menu filters style

4a44d45

got rid of menu icon

a103012

Merge branch 'master' into add-filters

da79336

put header component in

8b3dc76

Merge branch 'master' into add-filters

562281b

added courseSearch to flux, ability to store term filters in redux

b6e8ad4

term filters working

b361977

removed unused files and dependency

70881bc

terms filter functional

621d6e5

prettier

3eded99

drewvolz requested review from hawkrives, rye and a team February 22, 2018 19:40

drewvolz added the type/enhancement label Feb 22, 2018

hawkrives reviewed Feb 22, 2018

View reviewed changes

hannesmcman added 5 commits February 22, 2018 16:54

added status and lab only filters

02850ac

prettier

9c16fd0

add ge filter

135a015

generalize data loading for filters

233825a

add department filter

377c22e

hawkrives previously requested changes Feb 24, 2018

View reviewed changes

switch from bluebird to pProps dependency

4dc9f04

StoDevX deleted a comment from buildsize bot Feb 26, 2018

prettier

2fdeac6

StoDevX deleted a comment from buildsize bot Feb 26, 2018

formatted terms for toolbar..pissed off flow

57020a9

drewvolz reviewed Mar 7, 2018

View reviewed changes

StoDevX deleted a comment from buildsize bot Mar 7, 2018

hawkrives added 2 commits March 6, 2018 23:12

add functions to filter lists of specs

38ded64

fix up flow types in SIS/filter-toolbar

e165bba

drewvolz approved these changes Mar 7, 2018

View reviewed changes

hawkrives merged commit 26f14d3 into master Mar 7, 2018

hawkrives deleted the add-filters branch March 28, 2018 02:03

rye added this to the v2.6 milestone Jul 20, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Add filters to course search #2378

[WIP] Add filters to course search #2378

hannesmcman commented Feb 22, 2018 •

edited

Loading

hannesmcman commented Feb 22, 2018 •

edited by drewvolz

Loading

hannesmcman commented Feb 22, 2018

hawkrives commented Feb 22, 2018 •

edited

Loading

hawkrives left a comment

hawkrives Feb 22, 2018

drewvolz Feb 22, 2018 •

edited

Loading

hannesmcman Feb 22, 2018 •

edited

Loading

hawkrives Feb 22, 2018

hannesmcman Feb 23, 2018

hawkrives Feb 22, 2018

drewvolz Feb 22, 2018 •

edited

Loading

hannesmcman Feb 22, 2018

hannesmcman commented Feb 22, 2018

hannesmcman commented Feb 22, 2018

hawkrives commented Feb 22, 2018

drewvolz commented Feb 22, 2018 •

edited

Loading

hawkrives commented Feb 22, 2018

drewvolz commented Feb 22, 2018

hawkrives commented Feb 22, 2018

drewvolz commented Feb 22, 2018

stodevx-bot commented Feb 23, 2018 •

edited

Loading

p-props

Install

Usage

API

pProps(input)

input

Related

License

hawkrives Feb 24, 2018

drewvolz Mar 7, 2018

buildsize bot commented Mar 7, 2018 •

edited

Loading

hawkrives commented Mar 7, 2018

stodevx-bot commented Mar 7, 2018

[WIP] Add filters to course search #2378

[WIP] Add filters to course search #2378

Conversation

hannesmcman commented Feb 22, 2018 • edited Loading

hannesmcman commented Feb 22, 2018 • edited by drewvolz Loading

hannesmcman commented Feb 22, 2018

hawkrives commented Feb 22, 2018 • edited Loading

hawkrives left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

drewvolz Feb 22, 2018 • edited Loading

Choose a reason for hiding this comment

hannesmcman Feb 22, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

drewvolz Feb 22, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hannesmcman commented Feb 22, 2018

hannesmcman commented Feb 22, 2018

hawkrives commented Feb 22, 2018

drewvolz commented Feb 22, 2018 • edited Loading

hawkrives commented Feb 22, 2018

drewvolz commented Feb 22, 2018

hawkrives commented Feb 22, 2018

drewvolz commented Feb 22, 2018

stodevx-bot commented Feb 23, 2018 • edited Loading

p-props

Install

Usage

API

pProps(input)

input

Related

License

Choose a reason for hiding this comment

Choose a reason for hiding this comment

buildsize bot commented Mar 7, 2018 • edited Loading

hawkrives commented Mar 7, 2018

stodevx-bot commented Mar 7, 2018

iOS Report

hannesmcman commented Feb 22, 2018 •

edited

Loading

hannesmcman commented Feb 22, 2018 •

edited by drewvolz

Loading

hawkrives commented Feb 22, 2018 •

edited

Loading

drewvolz Feb 22, 2018 •

edited

Loading

hannesmcman Feb 22, 2018 •

edited

Loading

drewvolz Feb 22, 2018 •

edited

Loading

drewvolz commented Feb 22, 2018 •

edited

Loading

stodevx-bot commented Feb 23, 2018 •

edited

Loading

buildsize bot commented Mar 7, 2018 •

edited

Loading